MOSIP-44176:ARC - Run the ARC UI automation in Arab language

[damodarguru]

MOSIP-44176:ARC - Run the ARC UI automation in Arab language

Summary by CodeRabbit

• Tests & QA
  • Improved test reliability with stronger retry logic and longer timeouts.
  • Streamlined biometric and registration flows for more consistent verification and session continuity.
  • Better auto-logout handling and recovery during flows.
• Localization
  • Enhanced multi-language UI handling and updated localized selectors across several pages.
• Settings
  • Introduced dynamic job-based sync checks and actions in Settings.
• Account
  • Updated password reset navigation to improve return-to-app behavior.

[coderabbitai]

Walkthrough

This PR updates Android UI tests and page objects: adds context-switching and stronger retry/wait logic in BasePage, renames supervisor→operator biometric checks across locales, introduces job-parameterized Settings APIs, modifies Keycloak webflow, adjusts many locale-specific locators/flows, and changes several test navigation sequences and page interactions.

Changes

Cohort / File(s)	Summary
Test case navigation & flows ui-test/src/main/java/regclient/androidTestCases/BiometricCorrection.java, .../LoginTest.java, .../NewRegistrationAdult.java, .../NewRegistrationInfant.java, .../NewRegistrationMinor.java, .../NewRegistrationMinorException.java, .../ResetPassword.java, .../LostUin.java	Enabled/asserted additional checks, swapped Back→Next in many flows, added retries/waits around auth pages, language-aware page instantiation and repeated navigation steps, removed Documents step in LostUin, added document upload in NewRegistrationAdult, and adjusted Keycloak navigation calls.
Base framework & utilities ui-test/src/main/java/regclient/page/BasePage.java	Increased many timeouts (10s→20s), added clickOnElement2 and sendKeys helpers, hardened findElementWithRetry with staleness handling/scroll+retry, added openArcApplication() plus switchToNativeContext()/switchToWebContext() for context management, and increased click-at-coordinates pause.
Keycloak & auth handling ui-test/src/main/java/regclient/page/KeycloakPage.java	Added openKeycloakPage() and waitForLoginPage(), replaced some element-based webview input with By/sendKeys, removed logoutButton field, and changed resumeArcApplication() signature from boolean→void (now resumes app via BasePage).
Settings: job-parameterized sync ui-test/src/main/java/regclient/page/SettingsPage.java, .../SettingsPageEnglish.java, .../SettingsPageArabic.java, .../SettingsPageFrench.java, .../SettingsPageHindi.java, .../SettingsPageKannada.java, .../SettingsPageTamil.java	Replaced fixed Master Data Sync APIs with parameterized isJobDisplayed(String) and clickOnSyncButton(String) across locales; locator and scrolling changes to locate job entries dynamically.
Supervisor → Operator rename ui-test/src/main/java/regclient/page/SupervisorBiometricVerificationpage.java, many SupervisorBiometricVerificationpage*.java	Renamed field and method signatures: supervisorBiometricVerificationPageTitle → operatorBiometricVerificationPageTitle and isSupervisorBiometricVerificationPageLoaded() → isOperatorBiometricVerificationPageLoaded() across multiple locale implementations.
ManageApplications / dismiss/back behavior ui-test/src/main/java/regclient/page/ManageApplicationsPage.java, .../ManageApplicationsPageEnglish.java, .../ManageApplicationsPageArabic.java	Removed clickDismissButton() abstract/implementations and dismissButton fields; changed English back-button lookup and clickOnBackButton() now uses driver.navigate().back().
Biometric & preview pages ui-test/src/main/java/regclient/page/BiometricDetailsPage.java, .../PreviewPageEnglish.java, .../PreviewPageArabic.java, .../DocumentuploadPageEnglish.java	Commented out handleBiometricDetails, replaced biometric-correction title checks with scroll-into-view implementations, added scrollToText helper in Arabic preview, and changed DocumentUpload page display checks to use horizontal scrolling.
Camera & document upload ui-test/src/main/java/regclient/page/CameraPage.java, .../DocumentUploadPage*.java	Simplified camera OK click to direct element click via new okBtn and clickOnElement2, added small wait/sync steps in document upload pages.
Locale-specific locator & behavior updates ui-test/src/main/java/regclient/pages/* (arabic, english, french, hindi, kannada, tamil, etc.)	Widespread locator adjustments (Arabic text fixes, some Arabic pages using English keywords for biometric headers), input helper swaps (use of clickAndsendKeysToTextBox2), zoom click coordinate changes in several locales, added auto-logout handling and polling in BiometricDetailsPageArabic, and various timing/synchronization tweaks.
API & config edits ui-test/src/main/java/regclient/api/FetchUiSpec.java, ui-test/src/main/resources/DesiredCapabilities.json	Commented out two public biometric helper methods in FetchUiSpec; increased Appium newCommandTimeout from 600→3600.
Misc field/signature edits assorted page classes (DemographicPages, PendingApproval, OperationalTaskPage, Supervisor pages per locale)	Removed/modified fields (postalHeader, logoutButton), removed clickDismissButton() implementations, switched some cached element clicks to locator-time lookups, and minor method/body updates across locales.

Sequence Diagram(s)

mermaid
sequenceDiagram
participant Test as TestRunner
participant Base as BasePage
participant App as MobileApp (NATIVE)
participant Web as Keycloak (WEB)
participant Profile as ProfilePage
Test->>Base: openArcApplication()
Base->>App: activate app (ensure NATIVE)
Base->>Base: switchToWebContext() (when needed)
Base->>Web: openKeycloakPage() / waitForLoginPage()
Web-->>Test: Keycloak login UI shown
Test->>Web: enter credentials / submit
Web->>Base: resumeArcApplication()
Base->>App: switchToNativeContext()
App->>Profile: show logout popup / profile state
Profile-->>Test: isLogoutPopUpMessageDisplayed() result

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~75 minutes

Possibly related PRs

• MOSIP-44311: Fix and optimize ARC UI automation failures #671 — overlaps same UI test files and page-object changes (context/locator handling, retries, method renames and removals).

Suggested reviewers

• mohanachandran-s
• ase-101

Poem

"🐇 I hopped through waits, locators, and a rename,

From Supervisor to Operator the titles came.
Jobs now found by name, Keycloak opens a gate,
Arabic, French, and Tamil joined the state.
Tests retry, scroll, and patiently wait."

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The PR title mentions running ARC UI automation in Arab language, but the changeset includes substantial refactoring across multiple test classes (retry mechanisms, navigation flow changes, API modifications) and numerous English/French/Hindi/Kannada/Tamil page updates alongside Arabic changes.	Update the title to reflect the full scope: include mention of test flow refactoring, navigation changes, and multi-language page updates. For example: 'MOSIP-44176: Refactor ARC UI automation tests with enhanced retry logic and multi-language page support'
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

ui-test/src/main/java/regclient/pages/arabic/BiometricDetailsPageArabic.java (5)

3-3: Remove unused imports.

Three imports are not referenced anywhere in the active code:

• Line 3: org.junit.Assert.assertTrue — unused (and wrong framework per project conventions)
• Line 19: SupportsContextSwitching — unused
• Line 27: RegistrationTasksPageEnglish — unused (the method now correctly returns RegistrationTasksPageArabic)

Proposed fix

-import static org.junit.Assert.assertTrue;
-
 import java.time.Duration;

-import io.appium.java_client.remote.SupportsContextSwitching;

-import regclient.pages.english.RegistrationTasksPageEnglish;

Also applies to: 19-19, 27-27

---

161-165: Local By variable shadows the WebElement field of the same name.

The local additionalInfoRequestIdTextbox (a By) on line 162 shadows the class field declared at line 52 (a WebElement). This compiles fine but is confusing — enterAdditionalInfoUsingEmail (line 190) uses the field while this method uses the local. Rename the local to avoid ambiguity.

Proposed fix

 public boolean isAdditionalInfoRequestIdTextboxDisplayed() {
-    By additionalInfoRequestIdTextbox = MobileBy
+    By additionalInfoLocator = MobileBy
         .AndroidUIAutomator("new UiSelector().className(\"android.widget.EditText\").instance(0)");
-    return isElementDisplayed(additionalInfoRequestIdTextbox);
+    return isElementDisplayed(additionalInfoLocator);
 }

---

167-226: Use the declared logger instead of System.out.println.

A Logger is declared at line 243 but all diagnostic output in this method uses System.out.println. This loses log-level filtering and structured output.

Proposed fix (representative lines)

-            System.out.println("Found id: " + id + " -> finalId: " + finalId);
+            logger.info("Found id: {} -> finalId: {}", id, finalId);

-            System.out.println("Entered finalId: " + finalId);
+            logger.info("Entered finalId: {}", finalId);

-            System.out.println("Auto-logout popup displayed — staying logged in.");
+            logger.info("Auto-logout popup displayed — staying logged in.");

-            System.out.println("ID not found yet. Elapsed " + (elapsed / 1000) + "s, remaining " + (remainingMs / 1000)
-                    + "s. Sleeping " + pollIntervalSeconds + "s.");
+            logger.info("ID not found yet. Elapsed {}s, remaining {}s. Sleeping {}s.",
+                    elapsed / 1000, remainingMs / 1000, pollIntervalSeconds);

---

228-232: Method name typeAndVerify is misleading — no verification is performed.

The method clicks, clears, and sends keys but never verifies the entered value. Either rename to typeInto / clearAndType, or add actual verification (e.g., read back the element's text and assert).

---

245-299: Large commented-out code block should be removed or tracked externally.

~55 lines of commented-out code adds noise. If this is intended for future use, consider tracking it in a ticket/issue rather than leaving it in the source.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 9

Note

Due to the large number of review comments, Critical, Major severity comments were prioritized as inline comments.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (4)

ui-test/src/main/java/regclient/pages/english/DemographicDetailsPageEnglish.java (2)

388-398: ⚠️ Potential issue | 🟠 Major

Bug: reference equality == "" on String — always false in practice.

Line 394 uses == "" which compares object references, not string content. This condition will almost never be true, so checkSecondLanguageTextBoxNotNull can return true even when the text box contains an empty string.

🐛 Proposed fix

-		if (getTextFromLocator(findElementWithRetry(By.xpath("//android.view.View[contains(`@content-desc`, \""
-				+ FetchUiSpec.getValueUsingId(id)
-				+ "\")]/parent::android.view.View/following-sibling::android.view.View/descendant::android.widget.EditText[2]"))) == null
-				|| getTextFromLocator(findElementWithRetry(By.xpath("//android.view.View[contains(`@content-desc`, \""
-						+ FetchUiSpec.getValueUsingId(id)
-						+ "\")]/parent::android.view.View/following-sibling::android.view.View/descendant::android.widget.EditText[2]"))) == "")
-			return false;
-		else
-			return true;
+		String text = getTextFromLocator(findElementWithRetry(By.xpath("//android.view.View[contains(`@content-desc`, \""
+				+ FetchUiSpec.getValueUsingId(id)
+				+ "\")]/parent::android.view.View/following-sibling::android.view.View/descendant::android.widget.EditText[2]")));
+		return text != null && !text.isEmpty();

This also avoids the redundant second findElementWithRetry + XPath evaluation for the same element.

---

58-59: ⚠️ Potential issue | 🟠 Major

maleButtonInArabic accessibility locator is stale.

The Arabic variant in DemographicDetailsPageArabic.java uses "ذكر" for its maleButton accessibility locator (line 28), but maleButtonInArabic in the English variant still references the outdated "آحرون". Update the accessibility string to "ذكر" to match the current Arabic UI.

ui-test/src/main/java/regclient/pages/english/SupervisorBiometricVerificationpageEnglish.java (1)

289-292: ⚠️ Potential issue | 🟠 Major

isZoomButtonDisplayed() is hardcoded to return true — the actual check is commented out.

This bypasses the zoom button verification entirely, meaning tests relying on this method will never detect a missing zoom button. If the original locator is unreliable, fix the locator rather than short-circuiting the check. If this is a temporary workaround, add a TODO comment explaining when it should be reverted.

ui-test/src/main/java/regclient/androidTestCases/BiometricCorrection.java (1)

1685-1700: ⚠️ Potential issue | 🟡 Minor

Preview page instantiation is inside the for loop — should be after it.

Lines 1685-1699 create the previewPage object unconditionally on every iteration of the for (String screen : screenOrder) loop. This means the page object is needlessly re-created for consent, demographic, document, and biometric screens. In the adult test (lines 782-797), the equivalent block is correctly placed after the loop.

While functionally harmless (the last assignment wins), this is inconsistent with the adult test pattern and obscures intent.

🔧 Move the block after the loop's closing brace

             ((HidesKeyboard) driver).hideKeyboard();
             biometricDetailsPage.clickOnContinueButton();
         }
-
-        if ("eng".equalsIgnoreCase(language)) {
-            previewPage = new PreviewPageEnglish(driver);
-        } else if ("hin".equalsIgnoreCase(language)) {
-            ...
-        }
     }
+
+    if ("eng".equalsIgnoreCase(language)) {
+        previewPage = new PreviewPageEnglish(driver);
+    } else if ("hin".equalsIgnoreCase(language)) {
+        ...
+    }

     assertTrue(previewPage.isBiometricCorrectionTitleDisplayed(),

🤖 Fix all issues with AI agents

In `@ui-test/src/main/java/regclient/page/CameraPage.java`:
- Around line 26-28: The device-specific locator
com.hihonor.camera:id/done_button used for the field okBtn will fail on
non-Honor devices; update clickOkButton() to try a fallback chain: first attempt
to find and click okBtn, if not present catch the exception and try the existing
okButton xpath locator, then try other known vendor IDs (e.g., samsung/pixel
variants) or a configurable locator list. Make the locator list configurable
(e.g., via a static List<String> or a properties entry) so new OEM IDs can be
added without code changes, and ensure each attempt handles
NoSuchElementException and only throws if all fallbacks fail.

In
`@ui-test/src/main/java/regclient/pages/arabic/ApplicantBiometricsPageArabic.java`:
- Around line 165-168: The method clickOnZoomButton currently uses
device-specific coordinates (clickAtCoordinates(1035, 1077)), which is fragile;
change clickOnZoomButton to interact with the zoomButton WebElement instead
(e.g., call click() on zoomButton or compute a percentage-relative click based
on zoomButton's bounds) so the action works across resolutions, and remove the
now-unused zoomButton field if it's left unused; update any helper calls to use
a relative-offset helper (e.g., clickRelativeToElement(zoomButton,...)) or
simply zoomButton.click() in ApplicantBiometricsPageArabic to fix the fragility.

In
`@ui-test/src/main/java/regclient/pages/arabic/BiometricDetailsPageArabic.java`:
- Around line 162-165: The method clickOnStayLoggedInButton in
BiometricDetailsPageArabic incorrectly returns and instantiates
RegistrationTasksPageEnglish; update it to return the Arabic page object by
changing the return type and the instantiated class to
RegistrationTasksPageArabic (keeping the same driver argument/constructor usage
as in the existing call) so the Arabic page object and locators are used after
the click.
- Around line 239-247: The isAutoLogoutPopupDisplayed() method currently uses a
10-minute WebDriverWait which can consume the entire polling budget in
enterAdditionalInfoUsingEmail; change isAutoLogoutPopupDisplayed() to use a
short wait (e.g., Duration.ofSeconds(5) or 10) or replace the long wait with a
non-blocking presence check (like findElements(...).isEmpty() or a short
ExpectedConditions.visibilityOf with a small timeout) so it only checks current
visibility and returns quickly while preserving the existing try/catch behavior;
update the WebDriverWait instantiation in isAutoLogoutPopupDisplayed()
accordingly.
- Around line 3-4: The file BiometricDetailsPageArabic.java currently statically
imports two conflicting assertTrue methods causing ambiguity; replace both JUnit
imports with the TestNG static import (import static
org.testng.Assert.assertTrue;) so the class (BiometricDetailsPageArabic) uses
the project-consistent org.testng.Assert.assertTrue; ensure you remove both
org.junit.Assert.assertTrue and org.junit.jupiter.api.Assertions.assertTrue
imports and keep only the TestNG import (or remove all static assert imports if
assertions shouldn't be in a page object).

In
`@ui-test/src/main/java/regclient/pages/arabic/UpdateOperatorBiometricspageArabic.java`:
- Around line 62-75: The zoomButton selector in
UpdateOperatorBiometricspageArabic is too generic (uses new
UiSelector().className("android.view.View").clickable(true)) and can match the
wrong element; replace the zoomButton locator with a specific locator such as a
content-desc, resource-id, or the same scoped XPath used in the English page
(for example //android.widget.ScrollView/android.view.View[3]) or an XPath
scoped under the relevant capturer header (irisCapturerHeader,
rightHandCapturerHeader, leftHandCapturerHeader, thumbsCapturerHeader,
faceCapturerHeader) to reliably target the actual zoom control.

In
`@ui-test/src/main/java/regclient/pages/french/ApplicantBiometricsPageFrench.java`:
- Around line 164-167: The clickOnZoomButton method uses fragile absolute
coordinates (clickAtCoordinates(1035, 1077)); change it to perform an
element-based click on the existing zoomButton locator instead: wait for the
zoomButton to be visible/clickable (e.g., explicit wait), then call the click
action on zoomButton; if the current zoomButton locator is flaky, improve it
(stronger XPath, resource-id, accessibility id, or UiAutomator selector) so the
element can be reliably found across devices and resolutions.

In
`@ui-test/src/main/java/regclient/pages/hindi/SupervisorBiometricVerificationpageHindi.java`:
- Around line 11-12: Update the accessibility locator for the
operatorBiometricVerificationPageTitle field: replace the current
`@AndroidFindBy`(accessibility = "Supervisor's Biometric Verification") value with
the correct Hindi/localized string for "Operator Biometrics" (or confirm the
exact Hindi UI text) so the accessibility locator matches the renamed field
operatorBiometricVerificationPageTitle and the other locale implementations.

In `@ui-test/src/main/java/regclient/pages/tamil/SettingsPageTamil.java`:
- Around line 248-251: clickOnSyncButton currently clicks an EditText via
"//android.widget.EditText[contains(`@hint`,'...')]" which targets the input field
instead of the actual sync button; update clickOnSyncButton(String jobName) to
locate and click the same element getSyncButton(jobName) uses (e.g. an XPath
using content-desc and a clickable node like
"//android.view.View[contains(`@content-desc`,'" + jobName +
"')]//*[`@clickable`='true']") or simply call getSyncButton(jobName) and click
that element so the method name and behavior match the intended sync button
action.

🟡 Minor comments (12)

ui-test/src/main/java/regclient/androidTestCases/NewRegistrationInfant.java-545-549 (1)

545-549: ⚠️ Potential issue | 🟡 Minor

Duplicate clickServerStatusDropdown() call — verify this is intentional and not a toggle.

clickServerStatusDropdown() is called twice in succession (Lines 545 and 547). If this element behaves as a toggle, the second click would close what the first click opened, leaving the dropdown in its original state before enterAID(Aid) is called on Line 549.

If this is a workaround for a flaky first-click in the Arabic layout, consider adding an explicit wait or a conditional retry instead, so the intent is clear and the behavior is deterministic.

 		manageApplicationsPage.clickServerStatusDropdown();
-		
-		manageApplicationsPage.clickServerStatusDropdown();
+		// If a second click is needed, add a comment explaining why,
+		// or use a wait/retry mechanism instead.

ui-test/src/main/java/regclient/pages/arabic/UpdateOperatorBiometricspageArabic.java-125-126 (1)

125-126: ⚠️ Potential issue | 🟡 Minor

Overly broad UiAutomator selector for zoomButton — will match the first clickable android.view.View on screen.

new UiSelector().className("android.view.View").clickable(true) has no distinguishing constraint (index, description, etc.), so it resolves to whichever clickable View Appium encounters first. If the page has other clickable views before the zoom button (or the layout order shifts), tests will interact with the wrong element.

Consider adding a more specific constraint, e.g., an .instance(N) index or a partial content-description/resource-id match, to target the zoom button reliably.

ui-test/src/main/resources/DesiredCapabilities.json-15-15 (1)

15-15: ⚠️ Potential issue | 🟡 Minor

newCommandTimeout of 3600s (1 hour) is very generous — consider whether this masks hung sessions.

Increasing from 600 to 3600 means Appium will wait up to 1 hour before timing out an idle session. While longer test flows justify some increase, a 6× bump risks leaving zombie sessions alive indefinitely if a test hangs. Consider a more moderate value (e.g., 1200–1800s) and fixing root-cause timing issues in individual test steps instead.

ui-test/src/main/java/regclient/pages/english/DocumentuploadPageEnglish.java-54-59 (1)

54-59: ⚠️ Potential issue | 🟡 Minor

getScreenTitle may return null, producing a broken UiAutomator selector.

If FetchUiSpec.getScreenTitle("Documents") returns null (e.g., UiSpec not loaded or screen name mismatch), the selector string will contain the literal text "null", leading to a confusing element-not-found failure instead of a clear error. Consider adding a null-check or assertion before constructing the selector.

ui-test/src/main/java/regclient/pages/arabic/IntroducerBiometricPageArabic.java-48-64 (1)

48-64: ⚠️ Potential issue | 🟡 Minor

Arabic capturer header locators are less specific than other language variants — risk of false matches.

The new XPath patterns match very broad English terms like 'Iris', 'RightHand', 'Face', and 'Exception' without including a capturer/header qualifier. Compare with French ('Iris Capturer') or Kannada ('Iris ಸೆರೆಹಿಡಿಯಿರಿ'), which include a more specific suffix. A bare contains(@content-desc, 'Iris') could match scan title elements or other UI components containing "Iris" in their content description.

Consider tightening the locators, e.g.:

-	`@AndroidFindBy`(xpath = "//*[contains(`@content-desc`, 'Iris')]")
+	`@AndroidFindBy`(xpath = "//*[contains(`@content-desc`, 'Iris Capture')]")

ui-test/src/main/java/regclient/pages/arabic/SettingsPageArabic.java-227-240 (1)

227-240: ⚠️ Potential issue | 🟡 Minor

validateJobCardFields logic differs from other locales.

The Arabic implementation checks only "Next Run" and "Last Sync" (English strings), while the Hindi and English variants also check for "Cron Expression" and the jobName itself. This inconsistency may indicate a partial update or could lead to weaker validation in Arabic tests.

ui-test/src/main/java/regclient/page/SettingsPage.java-53-58 (1)

53-58: ⚠️ Potential issue | 🟡 Minor

Good API generalization from fixed Master Data Sync to parameterized job-based methods.

The shift to clickOnSyncButton(String jobName) and isJobDisplayed(String jobName) is a clean generalization. All language-specific subclasses properly implement these new abstract methods, and test code (Settings.java) correctly uses them with the job name parameter.

Remove the deprecated isMasterDataSyncCardDisplayed() and clickOnMasterDataSyncButton() methods from the following subclasses—they are no longer part of the abstract contract and have become dead code:

• SettingsPageTamil
• SettingsPageHindi
• SettingsPageFrench
• SettingsPageKannada

(Arabic and English implementations are already clean.)

ui-test/src/main/java/regclient/pages/arabic/SupervisorBiometricVerificationpageArabic.java-116-117 (1)

116-117: ⚠️ Potential issue | 🟡 Minor

Broad zoomButton selector may match unintended elements.

new UiSelector().className("android.view.View").clickable(true) will match the first clickable android.view.View on the entire screen. This is fragile — if the page layout changes or another clickable view appears before the zoom button, this locator will break silently (clicking the wrong element).

Consider adding a more specific constraint (e.g., index, content-desc, or a parent-child relationship) to make this locator more resilient.

ui-test/src/main/java/regclient/page/BasePage.java-400-403 (1)

400-403: ⚠️ Potential issue | 🟡 Minor

Stale comment: says "200ms" but pause is now 600ms.

-				.addAction(new Pause(finger, Duration.ofMillis(600))) // Pause for 200ms
+				.addAction(new Pause(finger, Duration.ofMillis(600))) // Pause for 600ms

ui-test/src/main/java/regclient/pages/kannada/SettingsPageKannada.java-234-243 (1)

234-243: ⚠️ Potential issue | 🟡 Minor

Scroll targets generic EditText, not the specific job element.

scrollIntoView scrolls to the first EditText on screen, which may not be the one matching jobName. For long lists, the target job could remain off-screen. Consider scrolling to the specific element:

Proposed fix

 public boolean isJobDisplayed(String jobName) {
-    // Scroll to jobs list (safe for long lists)
-    driver.findElement(MobileBy.AndroidUIAutomator("new UiScrollable(new UiSelector().scrollable(true))"
-            + ".scrollIntoView(new UiSelector().className(\"android.widget.EditText\"))"));
+    driver.findElement(MobileBy.AndroidUIAutomator("new UiScrollable(new UiSelector().scrollable(true))"
+            + ".scrollIntoView(new UiSelector().className(\"android.widget.EditText\").textContains(\"" + jobName + "\"))"));

     By job = By.xpath("//android.widget.EditText[contains(`@hint`,'" + jobName + "')]");
     return isElementDisplayed(job);
 }

ui-test/src/main/java/regclient/pages/tamil/SettingsPageTamil.java-237-246 (1)

237-246: ⚠️ Potential issue | 🟡 Minor

Scroll target is generic — scrolls to the first EditText, not the specific job.

The UiScrollable.scrollIntoView uses className("android.widget.EditText") without filtering by job name. It will scroll to the first EditText on the page regardless of whether it's the target job. If the target job is further down, this won't scroll far enough.

Consider matching on the hint text instead:

Proposed fix

-		driver.findElement(MobileBy.AndroidUIAutomator("new UiScrollable(new UiSelector().scrollable(true))"
-				+ ".scrollIntoView(new UiSelector().className(\"android.widget.EditText\"))"));
+		driver.findElement(MobileBy.AndroidUIAutomator("new UiScrollable(new UiSelector().scrollable(true))"
+				+ ".scrollIntoView(new UiSelector().className(\"android.widget.EditText\").textContains(\"" + jobName + "\"))"));

ui-test/src/main/java/regclient/androidTestCases/BiometricCorrection.java-816-831 (1)

816-831: ⚠️ Potential issue | 🟡 Minor

Retry loop inconsistency between adult and minor biometric correction flows.

In the adult flow (here, lines 818-825), the retry loop includes Thread.sleep(2000) between attempts. In the minor flow (lines 1722-1729), the equivalent retry loop omits the sleep entirely. Without a pause, the minor flow may rapidly click "Continue" multiple times before the authentication page has a chance to render, which can lead to flaky test failures or unintended double-navigation.

🐛 Add the same sleep to the minor flow's retry loop

 for (int i = 0; i < 3; i++) {
     previewPage.clickOnContinueButton();
+    Thread.sleep(2000);

     if (authenticationPage.isAuthenticationPageDisplayed()) {
         isAuthenticationPageDisplayed = true;
         break;
     }
 }

🧹 Nitpick comments (34)

ui-test/src/main/java/regclient/page/BiometricDetailsPage.java (1)

42-43: Remove dead code instead of commenting it out.

Version control preserves history — prefer deleting the method declaration outright rather than leaving it commented out. Commented-out code adds noise and risks being left indefinitely.

-	
-//	public abstract void handleBiometricDetails();

ui-test/src/main/java/regclient/pages/english/ManageApplicationsPageEnglish.java (2)

87-90: backButton field is declared but never referenced.

The backButton WebElement (lines 87–90) is no longer used since clickOnBackButton() was changed to driver.navigate().back(). This leaves the field as dead code and the XPath locator will still be evaluated by PageFactory at initialization time, which adds unnecessary overhead and a potential point of failure if the element isn't present on screen.

Either remove the field or use it in clickOnBackButton().

Option A – remove the unused field

-	`@AndroidFindBy`(xpath =
-			  "(//android.widget.TextView[`@content-desc`='Manage Applications']" +
-			  "/ancestor::android.view.View)[1]//android.widget.Button")
-			private WebElement backButton;

Option B – use the field instead of driver.navigate().back()

 	public void clickOnBackButton() {
-		driver.navigate().back();
+		clickOnElement(backButton);
 	}

Also applies to: 233-235

---

87-90: Inconsistent indentation on the backButton field declaration.

The private WebElement backButton line (90) is indented with extra tabs compared to all other field declarations in this class. This appears to be a copy-paste artifact.

Suggested fix

 	`@AndroidFindBy`(xpath =
-			  "(//android.widget.TextView[`@content-desc`='Manage Applications']" +
-			  "/ancestor::android.view.View)[1]//android.widget.Button")
-			private WebElement backButton;
+			"(//android.widget.TextView[`@content-desc`='Manage Applications']" +
+			"/ancestor::android.view.View)[1]//android.widget.Button")
+	private WebElement backButton;

ui-test/src/main/java/regclient/androidTestCases/NewRegistrationMinorException.java (1)

155-169: Consider extracting language-based page instantiation into a factory or helper method.

The same if/else if language-dispatch block is repeated ~12 times in this file (and likely across other test classes). A simple factory method per page type — e.g., PageFactory.createLoginPage(language, driver) — or a Map<String, Supplier<T>> would collapse each block into a single call, making it far easier to add new languages and reducing the file from ~750 lines to roughly half.

This is a pre-existing pattern and not introduced by this PR, so it can be addressed separately.

Also applies to: 176-190, 195-209, 225-239, 242-256, 263-277, 284-298, 302-316

ui-test/src/main/java/regclient/androidTestCases/LostUin.java (1)

301-302: Commented-out code left in place.

handleBiometricDetails() is commented out while the manual biometric scan steps (lines 304–382) remain active below it. If handleBiometricDetails() is intended to replace that manual flow, enable it and remove the redundant code. If it's not ready yet, consider removing the commented line and tracking the refactor in a separate issue to avoid dead code in the test suite.

ui-test/src/main/java/regclient/androidTestCases/NewRegistrationMinor.java (1)

155-169: Consider a factory or map to eliminate the ~13 repeated language-dispatch if-else chains.

The identical if ("eng") … else if ("hin") … else if ("fra") … pattern is repeated roughly 13 times across this single method. A simple PageFactory or Map<String, Function<AppiumDriver, T>> per page type would collapse each block into a single line, dramatically improving readability and making it trivial to add new languages.

For example:

// A shared utility, e.g. PageFactory.java
public class PageFactory {
    private static final Map<String, Function<AppiumDriver, LoginPage>> LOGIN_PAGE_MAP = Map.of(
        "eng", LoginPageEnglish::new,
        "hin", LoginPageHindi::new,
        "fra", LoginPageFrench::new,
        "kan", LoginPageKannada::new,
        "tam", LoginPageTamil::new,
        "ara", LoginPageArabic::new
    );

    public static <T> T create(Map<String, Function<AppiumDriver, T>> map, String lang, AppiumDriver driver) {
        Function<AppiumDriver, T> ctor = map.get(lang.toLowerCase());
        if (ctor == null) throw new IllegalStateException("Unsupported language: " + lang);
        return ctor.apply(driver);
    }
}

Then each 12-line block becomes:

loginPage = PageFactory.create(PageFactory.LOGIN_PAGE_MAP, language, driver);

This is a pre-existing pattern so not blocking, but worth addressing to reduce the ~500 lines of boilerplate in this file alone.

Also applies to: 176-190

ui-test/src/main/java/regclient/pages/arabic/DocumentUploadPageArabic.java (3)

48-49: okButton field is declared but never referenced in any method.

This WebElement is annotated with a locator but no method in this class uses it. Either integrate it where needed (e.g., replacing cameraPage.clickOkButton() calls if this targets a different OK button) or remove it to avoid confusion.

---

5-12: Unused imports: Duration, TimeoutException, ExpectedConditions, WebDriverWait.

None of these are referenced in any method body. They appear to have been added alongside okButton for an explicit-wait approach that was never implemented. Remove them or use them in place of the waitTime() calls.

---

129-144: Multiple waitTime(1) calls — prefer explicit waits over fixed sleeps.

You've imported WebDriverWait and ExpectedConditions but aren't using them. Fixed sleeps are unreliable (too slow on fast devices, too short on slow ones). Consider replacing these with explicit waits for the expected condition (e.g., waiting for PopUpCloseButton visibility or retakeButton presence).

Example: replacing waitTime with explicit wait

-               waitTime(1);
-               clickOnElement(PopUpCloseButton);
+               new WebDriverWait(driver, Duration.ofSeconds(5))
+                   .until(ExpectedConditions.visibilityOf(PopUpCloseButton));
+               clickOnElement(PopUpCloseButton);

ui-test/src/main/java/regclient/pages/arabic/OperationalTaskPageArabic.java (1)

36-41: Local variable shadows the class field updateOperatorBiometricsButton.

The By variable declared at line 37 has the same name as the WebElement field at line 14-15. This makes the field effectively unused and the naming confusing. Consider either removing the unused field or renaming the local variable (e.g., updateOperatorBiometricsLocator).

ui-test/src/main/java/regclient/api/FetchUiSpec.java (2)

19-19: Unused imports: TestContext and BaseTest.

Neither org.springframework.test.context.TestContext nor regclient.BaseTest.BaseTest appear to be referenced anywhere in this file. These should be removed to avoid unnecessary dependencies.

Proposed fix

-import org.springframework.test.context.TestContext;
...
-import regclient.BaseTest.BaseTest;

Also applies to: 28-28

---

514-601: Prefer removing dead code over commenting it out.

Large commented-out blocks are a maintenance burden. Since the code is tracked in version control, it can be recovered from git history if needed later. Consider removing this block entirely.

ui-test/src/main/java/regclient/pages/english/PreviewPageEnglish.java (1)

52-53: Field biometricCorrectionTitle at line 52-53 appears unused after this change.

The new isBiometricCorrectionTitleDisplayed() method constructs a dynamic locator via FetchUiSpec.getTitleUsingId("BIO") instead of referencing the biometricCorrectionTitle field. Consider removing the unused field.

Also applies to: 89-95

ui-test/src/main/java/regclient/pages/arabic/RegistrationTasksPageArabic.java (1)

37-41: Remove commented-out code.

The old descriptionEndsWith locator on lines 37–38 is dead code. Since the replacement on line 40 is already in place, remove the commented block to keep the file clean.

Proposed fix

-//	`@AndroidFindBy`(uiAutomator = "new UiSelector().descriptionEndsWith(\"لوحة القيادة\")")
-//	private WebElement dashboardButton;
-
 	`@AndroidFindBy`(uiAutomator = "new UiSelector().descriptionMatches(\".*لوحة القيادة.*\")")
 	private WebElement dashboardButton;

ui-test/src/main/java/regclient/pages/arabic/AcknowledgementPageArabic.java (1)

46-50: Local variable goToHomeButton shadows the class field of the same name.

The By goToHomeButton on line 47 shadows the WebElement goToHomeButton field declared on line 28, making the field effectively dead code in this method. This is confusing for maintainers. Rename the local variable (e.g., goToHomeLocator) to avoid ambiguity.

Proposed fix

 public RegistrationTasksPage clickOnGoToHomeButton() {
-    By goToHomeButton = MobileBy.AccessibilityId("اذهب إلى المنزل");
-    click(goToHomeButton);
+    By goToHomeLocator = MobileBy.AccessibilityId("اذهب إلى المنزل");
+    click(goToHomeLocator);
     return new RegistrationTasksPageArabic(driver);
 }

ui-test/src/main/java/regclient/androidTestCases/LoginTest.java (2)

90-104: Massive duplication: language-switch blocks are repeated 8+ times across this file.

Each page object instantiation uses an identical if-else chain on language. Consider extracting a factory method or a Map<String, Function<AppiumDriver, T>> to eliminate this repetition. This would significantly improve readability and make adding new languages trivial.

Example factory approach

// In a shared utility or base test class:
`@SuppressWarnings`("unchecked")
public static <T> T createPage(String language, AppiumDriver driver, 
        Map<String, Function<AppiumDriver, T>> factories) {
    Function<AppiumDriver, T> factory = factories.get(language.toLowerCase());
    if (factory == null) {
        throw new IllegalStateException("Unsupported language: " + language);
    }
    return factory.apply(driver);
}

// Usage:
private static final Map<String, Function<AppiumDriver, LoginPage>> LOGIN_PAGES = Map.of(
    "eng", LoginPageEnglish::new,
    "hin", LoginPageHindi::new,
    "fra", LoginPageFrench::new,
    "kan", LoginPageKannada::new,
    "tam", LoginPageTamil::new,
    "ara", LoginPageArabic::new
);

LoginPage loginPage = createPage(language, driver, LOGIN_PAGES);

Also applies to: 145-159, 165-179, 187-201, 213-227, 247-261, 279-293, 298-312

---

456-456: Variable UpdateOperatorBiometricspage should follow Java naming conventions.

Local variables should start with a lowercase letter: updateOperatorBiometricspage.

ui-test/src/main/java/regclient/pages/arabic/SettingsPageArabic.java (1)

138-146: Inconsistent wait strategy: waitTime(2) vs explicit WebDriverWait in other locales.

SettingsPageHindi and SettingsPageEnglish use WebDriverWait with a 30-second timeout for isDeviceSettingsPageDisplayed() and isFaceDeviceCardDisplayed(), while this Arabic variant uses a hard 2-second sleep. This may cause flaky failures on slower devices.

Consider aligning with other locales

 public boolean isDeviceSettingsPageDisplayed() {
-    waitTime(2);
-    return isElementDisplayed(deviceSettingsPage);
+    try {
+        WebDriverWait wait = new WebDriverWait(driver, Duration.ofSeconds(30));
+        wait.until(ExpectedConditions.visibilityOf(deviceSettingsPage));
+        return isElementDisplayed(deviceSettingsPage);
+    } catch (TimeoutException e) {
+        return false;
+    }
 }

ui-test/src/main/java/regclient/pages/hindi/SettingsPageHindi.java (1)

203-209: Dead code: isMasterDataSyncCardDisplayed() and clickOnMasterDataSyncButton() are no longer part of the abstract API.

These methods were replaced by the parameterized isJobDisplayed(String) and clickOnSyncButton(String) in the base SettingsPage class. The old methods should be removed along with the unused masterDataSyncCard and masterDataSyncButton fields (lines 74-78).

ui-test/src/main/java/regclient/pages/english/SettingsPageEnglish.java (1)

112-116: Dead fields: masterDataSyncCard and masterDataSyncButton appear unused.

The abstract SettingsPage no longer declares isMasterDataSyncCardDisplayed() or clickOnMasterDataSyncButton(), and this class doesn't define those methods either. These fields (and their locators) can be removed.

ui-test/src/main/java/regclient/pages/kannada/SettingsPageKannada.java (1)

234-248: Duplicated logic across all locale-specific settings pages.

isJobDisplayed and clickOnSyncButton are identical across Kannada, French, English, Hindi, Tamil, and Arabic variants. Consider moving them to the SettingsPage base class to eliminate duplication.

ui-test/src/main/java/regclient/pages/french/PendingApprovalFrench.java (1)

129-135: Switching to clickAndsendKeysToTextBox2 uses driver.navigate().back() to dismiss keyboard.

This approach is used consistently across language variants in this PR. Be aware that driver.navigate().back() could trigger unintended navigation if the keyboard is not visible at the time of the call (e.g., navigating away from the current screen). The original hideKeyboard() call is more defensive in that scenario.

ui-test/src/main/java/regclient/androidTestCases/NewRegistrationAdult.java (1)

492-528: The operational tasks + pending approval flow after acknowledgement looks correct.

The test correctly navigates through the operational tasks and pending approval workflow using the same language-dispatch pattern. The flow logic is sound.

However, the language-dispatch if-else chains are repeated 15+ times throughout this single method. Consider extracting a factory/utility that maps language codes to page object constructors — this would dramatically reduce boilerplate and make adding new languages trivial.

,

ui-test/src/main/java/regclient/pages/arabic/DemographicDetailsPageArabic.java (1)

209-210: Remove commented-out code.

Line 209 has a commented-out line. Clean it up to avoid confusion.

Proposed fix

 				if (!isElementDisplayed(dropdownElement)) {
-//						clickOnElement(findElement(By.className("android.view.View")));
 						clickOnElement(nonForeignerOption);

ui-test/src/main/java/regclient/page/BasePage.java (3)

711-724: switchToWebContext() has no retry/polling unlike switchToWebViewIfAvailable().

The existing switchToWebViewIfAvailable() (line 483) polls for up to ~5 seconds for a webview context to appear. The new switchToWebContext() checks only once and throws immediately if no webview is found. If the webview takes a moment to initialize, this will fail. Consider adding a brief polling loop for consistency.

---

270-276: Swallowed interrupt flag in waitTime.

The InterruptedException handler calls e.printStackTrace() but does not restore the interrupt flag. While this is test utility code and unlikely to cause real issues, best practice is to restore the interrupt:

Proposed fix

 	public static void waitTime(int sec) {
 		try {
 			Thread.sleep(sec * 1000L);
 		} catch (InterruptedException e) {
-			e.printStackTrace();
+			Thread.currentThread().interrupt();
 		}
 	}

---

172-180: sendKeys(By, String) does not dismiss keyboard after input.

All similar helper methods (clickAndsendKeysToTextBox, clickAndsendKeysToTextBox2, sendKeysToTextBox) dismiss the keyboard after sending keys. This new method does not, which may leave the keyboard open and interfere with subsequent actions. If this is intentional (caller handles dismissal), consider a comment noting this.

ui-test/src/main/java/regclient/page/KeycloakPage.java (2)

126-134: Field placement and naming are confusing.

The By fields usernameTextBox1 and passwordTextBox1 are declared inline between methods rather than grouped with other field declarations, and their 1-suffix naming doesn't convey intent. Additionally, the original @FindBy WebElement fields usernameTextBox (line 33-34) and passwordTextBox (line 36-37) are now unused.

Consider removing the unused WebElement fields and renaming these with descriptive names (e.g., usernameLocator, passwordLocator), placed alongside other field declarations.

---

180-192: Manual polling loop — consider WebDriverWait.

waitForLoginPage() manually polls with Thread.sleep(1000) in a loop. Since WebDriverWait is already imported and used elsewhere in this file, it would be more idiomatic and concise:

Suggested refactor

 public void waitForLoginPage() {
-    for (int i = 0; i < 15; i++) {
-        try {
-            driver.findElement(By.id("username"));
-            return;
-        } catch (Exception e) {
-            try {
-                Thread.sleep(1000);
-            } catch (InterruptedException ignored) {}
-        }
-    }
-    throw new RuntimeException("Login page not loaded");
+    new WebDriverWait(driver, Duration.ofSeconds(15))
+        .until(ExpectedConditions.presenceOfElementLocated(By.id("username")));
 }

ui-test/src/main/java/regclient/pages/arabic/BiometricDetailsPageArabic.java (1)

251-305: Large block of commented-out code.

This ~55-line commented-out block adds noise. If it's needed for future reference, consider tracking it in a separate issue or branch rather than leaving it in the source.

ui-test/src/main/java/regclient/pages/arabic/PreviewPageArabic.java (2)

65-92: Inconsistent element lookup across the three display-check methods.

isDemographicInformationInPreviewPageDisplayed (line 68-70) performs a manual driver.findElement(...) and delegates to isElementDisplayed(...), whereas isDocumentsInformationInPreviewPageDisplayed and isBiometricsInformationInPreviewPagePageDisplayed use the @AndroidFindBy field's .isDisplayed() directly. This creates two behavioral differences:

1. The demographic method ignores the pre-declared demographicInformationInPreviewPage field (which already embeds a scrollIntoView), making it redundant with the explicit scrollToText call.
2. .isDisplayed() on a lazy-proxy field can throw NoSuchElementException (caught here), but isElementDisplayed() may have additional null/staleness handling, leading to subtly different failure modes.

Pick one consistent approach for all three methods — ideally reuse the @AndroidFindBy fields the same way or do manual lookups the same way.

♻️ Suggested consistent approach (using scrollToText + field)

 public boolean isDemographicInformationInPreviewPageDisplayed() {
     try {
         scrollToText("المعلومات الديموغرافية");
-        WebElement demographicInformationInPreviewPage = driver
-                .findElement(MobileBy.AndroidUIAutomator("new UiSelector().text(\"المعلومات الديموغرافية\")"));
-        return isElementDisplayed(demographicInformationInPreviewPage);
+        return demographicInformationInPreviewPage.isDisplayed();
     } catch (Exception e) {
         return false;
     }
 }

---

160-164: scrollToText is vulnerable to broken UiAutomator expressions and missing @SuppressWarnings.

Two concerns with this helper:

1. String injection: The text parameter is concatenated directly into the UiAutomator expression. If text ever contains a double-quote ("), backslash, or other special characters, the expression will be malformed and throw at runtime. While the current Arabic callers are safe, this is a public method.
2. Deprecation warning: MobileBy.AndroidUIAutomator is deprecated in Appium Java Client 8.x. The @SuppressWarnings("deprecation") on isBiometricCorrectionTitleDisplayed (line 155) addresses it there, but this method and the manual findElement on line 69 also use the same deprecated API without suppression.

Consider adding @SuppressWarnings("deprecation") and either making the method private (since it's only used internally) or adding basic escaping for the text parameter.

♻️ Proposed fix

+   `@SuppressWarnings`("deprecation")
-   public void scrollToText(String text) {
+   private void scrollToText(String text) {
        ((AndroidDriver) driver)
                .findElement(MobileBy.AndroidUIAutomator("new UiScrollable(new UiSelector().scrollable(true))"
                        + ".scrollIntoView(new UiSelector().text(\"" + text + "\"))"));
    }

ui-test/src/main/java/regclient/androidTestCases/BiometricCorrection.java (2)

171-185: Extract a factory/helper for language-based page instantiation to eliminate massive duplication.

The identical 6-branch if/else-if language-dispatch pattern is repeated 25+ times across this single file. Each block follows the same structure: check language, instantiate the corresponding page class, or throw. This violates DRY and makes the file extremely hard to maintain — adding a new language requires touching every block.

Consider a simple factory utility, e.g.:

public class PageFactory {
    `@SuppressWarnings`("unchecked")
    public static <T> T createPage(String language, AppiumDriver driver, 
            Class<? extends T> eng, Class<? extends T> hin, 
            Class<? extends T> fra, Class<? extends T> kan, 
            Class<? extends T> tam, Class<? extends T> ara) {
        // map-based lookup + reflection or a switch
    }
}

Or a Map<String, Function<AppiumDriver, T>> per page type. This would collapse each 10-line block into a single line.

Also applies to: 196-210, 216-230, 246-260, 264-278, 286-300, 307-336, 422-436, 450-464, 470-484, 493-507, 512-526, 564-578, 604-618, 628-642, 658-672, 677-706

---

544-551: Thread.sleep in retry loops — prefer explicit waits.

Multiple retry loops use Thread.sleep(2000) as the inter-attempt delay (lines 546, 591, 820, 908, 952, etc.). Hardcoded sleeps are a common source of flakiness — they're either too short (causing failures) or too long (wasting time). Appium's WebDriverWait with ExpectedConditions would be more robust and self-adjusting.

This is a broader pattern across both test methods and could be addressed incrementally.

Also applies to: 906-913