[MOSIP-44195] Update maven-publish-android-download.yaml#287
[MOSIP-44195] Update maven-publish-android-download.yaml#287Prafulrakhade wants to merge 1 commit into
Conversation
Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
WalkthroughThe Maven publish workflow step for Android downloads was updated to target the inji module instead of mosip. Maven metadata files and artifact paths referenced in the build output preparation step now point to io/inji directories. Changes
Poem
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/maven-publish-android-download.yaml:
- Around line 187-194: The comment "Zip only io/inji folder contents" is
inaccurate: the zip command `zip -r ../../build-outputs.zip io` recursively zips
the entire `io` directory (not just `io/inji`), and the `find ... -name
"maven-metadata*"` will only affect files under `io/inji` if that path exists;
either update the comment to reflect that the entire `io` directory is being
zipped, or change the zip command to `zip -r ../../build-outputs.zip io/inji` to
zip only `io/inji`; also verify the Gradle output path matches `io/inji` so the
`find` invocation actually deletes metadata files (adjust the `find` path if the
artifacts are produced elsewhere).
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/maven-publish-android-download.yaml
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
| - name: Prepare and zip build outputs | ||
| run: | | ||
| # Delete metadata* files from all modules inside io/mosip | ||
| find ${{ inputs.SERVICE_LOCATION }}/${{ inputs.ANDROID_SERVICE_LOCATION }}/build/staging/io/mosip -type f -name "maven-metadata*" -delete | ||
| # Delete metadata* files from all modules inside io/inji | ||
| find ${{ inputs.SERVICE_LOCATION }}/${{ inputs.ANDROID_SERVICE_LOCATION }}/build/staging/io/inji -type f -name "maven-metadata*" -delete | ||
|
|
||
| # Zip only io/mosip folder contents | ||
| # Zip only io/inji folder contents | ||
| cd ${{ inputs.SERVICE_LOCATION }}/${{ inputs.ANDROID_SERVICE_LOCATION }}/build/staging | ||
| zip -r ../../build-outputs.zip io |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, let's look at the full workflow file to understand the context
cat -n .github/workflows/maven-publish-android-download.yaml | head -200Repository: mosip/kattu
Length of output: 10599
🏁 Script executed:
# Search for references to io/mosip and io/inji in the entire codebase
echo "=== Searching for io/mosip references ==="
rg "io/mosip" -n
echo ""
echo "=== Searching for io/inji references ==="
rg "io/inji" -nRepository: mosip/kattu
Length of output: 231
🏁 Script executed:
# Look for build configuration files that might define the artifact structure
echo "=== Looking for build.gradle files ==="
fd -e gradle -o fd -e gradle.kts
echo ""
echo "=== Looking for pom.xml files ==="
fd -e pom.xml
echo ""
echo "=== Looking for Maven settings ==="
fd -e settings.gradle -o fd -e settings.gradle.ktsRepository: mosip/kattu
Length of output: 429
🏁 Script executed:
# Search for files that call this reusable workflow
rg "maven-publish-android-download" -n
# Also check if there are any references to the workflow in README or documentation
fd -type f -name "*.md"Repository: mosip/kattu
Length of output: 225
🏁 Script executed:
# Let's look at git history to understand what the previous path was
git log --oneline -n 20 -- ".github/workflows/maven-publish-android-download.yaml"Repository: mosip/kattu
Length of output: 119
🏁 Script executed:
# Check the exact changes in this file to see what was changed from io/mosip to io/inji
git diff HEAD~1 HEAD -- ".github/workflows/maven-publish-android-download.yaml" 2>/dev/null || echo "No git diff available"Repository: mosip/kattu
Length of output: 76
🏁 Script executed:
# Show the specific commit that updated the file
git show 5211955 -- ".github/workflows/maven-publish-android-download.yaml" | head -100Repository: mosip/kattu
Length of output: 2830
🏁 Script executed:
# Search for where this workflow is called or referenced
rg "maven-publish-android-download" --type yaml
rg "maven-publish-android-download" --type mdRepository: mosip/kattu
Length of output: 203
🏁 Script executed:
# Look for markdown/documentation files
find . -name "*.md" -type f | head -20Repository: mosip/kattu
Length of output: 678
🏁 Script executed:
# Get the specific section around lines 187-194 from the git show output
git show 5211955 -- ".github/workflows/maven-publish-android-download.yaml" | grep -A 30 "Prepare and zip"Repository: mosip/kattu
Length of output: 1560
🏁 Script executed:
# Search for documentation about this workflow
cat ./README.md | grep -i "maven-publish"
cat ./docs/maven-publish-to-nexus-readme.md 2>/dev/null | head -50Repository: mosip/kattu
Length of output: 1843
Update the comment to accurately reflect what the zip command does.
The comment on line 192 states "Zip only io/inji folder contents," but the actual zip command zips the entire io folder, which will include all Maven artifact modules, not just io/inji. Either update the comment to match the command's behavior or adjust the zip command if only io/inji should be included. Additionally, verify that the Gradle build configuration in calling repositories produces artifacts under the io/inji path structure; if not, the find command on line 190 will have no effect.
🤖 Prompt for AI Agents
In @.github/workflows/maven-publish-android-download.yaml around lines 187 -
194, The comment "Zip only io/inji folder contents" is inaccurate: the zip
command `zip -r ../../build-outputs.zip io` recursively zips the entire `io`
directory (not just `io/inji`), and the `find ... -name "maven-metadata*"` will
only affect files under `io/inji` if that path exists; either update the comment
to reflect that the entire `io` directory is being zipped, or change the zip
command to `zip -r ../../build-outputs.zip io/inji` to zip only `io/inji`; also
verify the Gradle output path matches `io/inji` so the `find` invocation
actually deletes metadata files (adjust the `find` path if the artifacts are
produced elsewhere).
2 participants
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.