Skip to content

MOSIP-44858: secure random changes to improve performance #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nagendra0721 wants to merge 6 commits into
base: release-1.3.x
Choose a base branch
from
Open

MOSIP-44858: secure random changes to improve performance #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
88d3f6a
MOSIP-44858: secure random changes to improve performance
nagendra0721 Apr 8, 2026
71be7cf
MOSIP-44858: test case fix
nagendra0721 Apr 8, 2026
1c0dcd1
MOSIP-44858: test case fix
nagendra0721 Apr 8, 2026
a72e2ff
MOSIP-44858: improve performance
nagendra0721 Apr 10, 2026
73c6be2
MOSIP-44858: test case fix
nagendra0721 Apr 15, 2026
643f499
zkcrytomaanger performance change
nagendra0721 May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions kernel/kernel-keymanager-service/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,11 @@
<artifactId>java-multibase</artifactId>
<version>1.1.1</version>
</dependency>
<dependency>
<groupId>io.mosip.kernel</groupId>
<artifactId>kernel-auth-adapter</artifactId>
<version>1.3.0</version>
</dependency>
</dependencies>

<distributionManagement>
Expand Down
7 changes: 2 additions & 5 deletions ...r-service/src/main/java/io/mosip/kernel/clientcrypto/service/impl/ClientCryptoFacade.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
public class ClientCryptoFacade {

private static final Logger LOGGER = KeymanagerLogger.getLogger(ClientCryptoFacade.class);
private static SecureRandom secureRandom = null;
private static final ThreadLocal<SecureRandom> SECURE_RANDOM_TL = ThreadLocal.withInitial(SecureRandom::new);
private static ClientCryptoService clientCryptoService = null;

@Autowired
Expand Down Expand Up @@ -201,11 +201,8 @@ public byte[] decrypt(byte[] dataToDecrypt) {
}

public static byte[] generateRandomBytes(int length) {
if(secureRandom == null)
secureRandom = new SecureRandom();

byte[] bytes = new byte[length];
secureRandom.nextBytes(bytes);
SECURE_RANDOM_TL.get().nextBytes(bytes);
return bytes;
}

Expand Down
9 changes: 3 additions & 6 deletions ...src/main/java/io/mosip/kernel/clientcrypto/service/impl/LocalClientCryptoServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@ class LocalClientCryptoServiceImpl implements ClientCryptoService {
private static final String PUBLIC_KEY = "reg.pub";
private static final String README = "readme.txt";

private static SecureRandom secureRandom = null;
protected static CryptoCoreSpec<byte[], byte[], SecretKey, PublicKey, PrivateKey, String> cryptoCore;
private ApplicationContext applicationContext;
private Boolean useResidentServiceModuleKey;
private String residentServiceAppId;

private static final ThreadLocal<SecureRandom> SECURE_RANDOM_TL = ThreadLocal.withInitial(SecureRandom::new);

/**
* Creates RSA Key pair under user's home directory and the same is used for further
Expand All @@ -74,7 +74,7 @@ class LocalClientCryptoServiceImpl implements ClientCryptoService {
if(!doesKeysExists()) {
setupKeysDir();
KeyPairGenerator keyGenerator = KeyPairGenerator.getInstance(ALGORITHM);
keyGenerator.initialize(KEY_LENGTH, new SecureRandom());
keyGenerator.initialize(KEY_LENGTH, SECURE_RANDOM_TL.get());
KeyPair keypair = keyGenerator.generateKeyPair();
createKeyFile(PRIVATE_KEY, keypair.getPrivate().getEncoded());
createKeyFile(PUBLIC_KEY, keypair.getPublic().getEncoded());
Expand Down Expand Up @@ -171,11 +171,8 @@ public boolean isTPMInstance() {
}

public static byte[] generateRandomBytes(int length) {
if(secureRandom == null)
secureRandom = new SecureRandom();

byte[] bytes = new byte[length];
secureRandom.nextBytes(bytes);
SECURE_RANDOM_TL.get().nextBytes(bytes);
return bytes;
}

Expand Down
Loading
Loading