Skip to content

[MOSIP-44914] Disable Slack notifications in workflow#155

Merged
ckm007 merged 1 commit into
developfrom
Ivanmeneges-patch-1
May 22, 2026
Merged

[MOSIP-44914] Disable Slack notifications in workflow#155
ckm007 merged 1 commit into
developfrom
Ivanmeneges-patch-1

Conversation

@Ivanmeneges
Copy link
Copy Markdown

@Ivanmeneges Ivanmeneges commented May 21, 2026

Summary by CodeRabbit

  • Chores
    • Disabled Slack notifications for job failures in the CI workflow for three jobs: sign-in-with-esignet, storybook-example deployment, and sonarcloud.

Review Change Stack

Signed-off-by: Ivanmeneges <ivan.anil016@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5c25f182-da20-4a95-a0de-b92f737919a2

📥 Commits

Reviewing files that changed from the base of the PR and between 0413b5b and 45a2114.

📒 Files selected for processing (1)
  • .github/workflows/push-trigger.yml

Walkthrough

Three Slack failure notification steps are disabled by commenting them out in the push-trigger GitHub Actions workflow. The same pattern—commenting out the 8398a7/action-slack@v3 action, SLACK_WEBHOOK_URL secret, and if: failure() condition—is applied across the sign-in-with-esignet, storybook-example, and sonarcloud jobs.

Changes

Disable Slack notifications in workflow jobs

Layer / File(s) Summary
Disable Slack notifications in three workflow jobs
.github/workflows/push-trigger.yml
Slack failure notification steps using 8398a7/action-slack@v3 are disabled across sign-in-with-esignet, storybook-example, and sonarcloud jobs by commenting out the step definition, SLACK_WEBHOOK_URL wiring, and failure condition.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🐰 Three notification steps now sleep beneath comments so deep,
No Slack pings shall call when jobs do weep,
The silence spreads across three jobs with care,
A workflow that whispers instead of flare! 🤫✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: disabling Slack notifications in the workflow by commenting out Slack action steps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch Ivanmeneges-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ckm007 ckm007 merged commit 974f924 into develop May 22, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants