chore(lexical/query): fix clippy 1.97 question_mark lint in next_block_boundary (#851)#852
Merged
Merged
Conversation
…k_boundary (#851) Rust 1.97.0's broadened clippy::question_mark lint fires on the match-with-early-None in BooleanScorer::next_block_boundary, failing every CI clippy gate. Replace it with the ? operator as clippy suggests; behavior is identical (early None return preserved).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rust 1.97.0 (on the CI runners since 2026-07-09) broadened
clippy::question_mark, which now fires on the match-with-early-NoneinBooleanScorer::next_block_boundary(laurus/src/lexical/query/scorer.rs:961) and fails every clippy gate repo-wide. First seen on PR #850'sTest laurus-wasmjob; the repo-level Clippy job passed there only because it still resolved the previous stable at run time.One-line-class fix: replace the match with the
?operator, exactly as clippy suggests. Behavior-identical — the earlyNonereturn is preserved, so the conservative "any clause without block info disables the skip" semantics are unchanged.Testing
cargo +1.97.0 clippy --workspace --all-targets --features laurus/embeddings-all -- -D warnings— cleancargo +1.97.0 clippy -p laurus-wasm --target wasm32-unknown-unknown -- -D warnings— clean (reproduces the CI failure before the fix)cargo fmt --checkclean; boolean scorer tests 36/36 greenCloses #851