Fixed console error related to innerHTML on missing sidebar elements, updated isNewerVersion calls#122
Open
IHaveThatPower wants to merge 1 commit intomouse0270:masterfrom
Open
Fixed console error related to innerHTML on missing sidebar elements, updated isNewerVersion calls#122IHaveThatPower wants to merge 1 commit intomouse0270:masterfrom
IHaveThatPower wants to merge 1 commit intomouse0270:masterfrom
Conversation
…nonstandard tweaking. Fixed deprecation warnings for isNewerVersion().
paulcheeba
added a commit
to paulcheeba/module-credits
that referenced
this pull request
Mar 16, 2025
Fixed console error related to innerHTML on missing sidebar elements, updated isNewerVersion calls mouse0270#122 fix by https://github.com/IHaveThatPower
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some escape hatches to the sidebar tweaks related to checking system versions for systems that do their own nonstandard tweaking (e.g. DND5e).
Also fixed deprecation warnings for uses of isNewerVersion() that weren't calling the foundry.utils method.