Add Python 3.13 support by removing construct version constraint#62
Open
faratech wants to merge 2 commits intomoyix:masterfrom
Open
Add Python 3.13 support by removing construct version constraint#62faratech wants to merge 2 commits intomoyix:masterfrom
faratech wants to merge 2 commits intomoyix:masterfrom
Conversation
- Remove upper bound constraint on construct dependency - The constraint 'construct<2.10' was preventing installation on Python 3.13 due to newer construct versions having imp module compatibility issues - Add explicit Python version classifiers including 3.13 - Add python_requires constraint for better dependency resolution - Tested successfully on Python 3.13 with construct 2.10.70 Fixes installation error: 'ModuleNotFoundError: No module named imp' The imp module was removed in Python 3.12+, and newer construct versions handle this properly, so removing the upper bound allows compatible versions to be installed automatically.
- Add *.egg-info/ directories - Add *.so shared libraries - Add build/ and dist/ directories
|
Works for s2e as well, would be great to merge. |
|
@moyix Gentle ping can this be merged! |
|
ICYMI I created this fork for one of my projects to depend on: https://github.com/v-p-b/pdbparse |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pdbparse failed to install on Python 3.13 due to a version constraint issue:
The
impmodule was removed in Python 3.12+, and the constraintconstruct<2.10prevented installation of newer construct versions that handle this properly.Solution
construct<2.10→construct>=2.9)Testing
Files Changed
setup.py: Updated dependency constraints and Python version classifiers.gitignore: Added build artifacts to ignore listVerification
This fix enables pdbparse to work with modern Python versions while maintaining backward compatibility.