fix(governance): clear knip unused exports after EntryCard split - #14
Open
moyunzero wants to merge 1 commit into
Open
fix(governance): clear knip unused exports after EntryCard split#14moyunzero wants to merge 1 commit into
moyunzero wants to merge 1 commit into
Conversation
Point knip ignore at EntryCard/**, unexport memo helpers and backoff constant, and drop unused AIErrorType.NO_TOKEN so verify:governance passes. Co-authored-by: Cursor <cursoragent@cursor.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
knip.jsonignore path from monolithEntryCard.tsxtoEntryCard/**after Phase 10 splitEntryCardProps/areEntryCardPropsEqual; barrel only re-exports defaultSECURE_STORE_SET_BACKOFF_MSmodule-private; remove unusedAIErrorType.NO_TOKENyarn verify:governance(knip → depcruise → boundaries)Test plan
yarn verify:governance— knip / dependency-cruiser / eslint-plugin-boundaries PASSverify:governanceon push tomasterafter mergeMade with Cursor