feat: push docker images to GAR repository#1263
Draft
bhearsum wants to merge 2 commits intomozilla-releng:masterfrom
Draft
feat: push docker images to GAR repository#1263bhearsum wants to merge 2 commits intomozilla-releng:masterfrom
bhearsum wants to merge 2 commits intomozilla-releng:masterfrom
Conversation
jcristau
reviewed
Jul 24, 2025
Contributor
jcristau
left a comment
jcristau
left a comment
There was a problem hiding this comment.
This looks pretty good, thanks!
| @@ -0,0 +1,44 @@ | |||
| #!/usr/bin/env bash | |||
Contributor
There was a problem hiding this comment.
Any reason to not just reuse the existing push_image.sh script, making DOCKER_ARCHIVE_TAG optional and passing the path to the secret as an env variable from the kind?
Contributor
Author
There was a problem hiding this comment.
There will be more changes than this later. In particular, we're going to be starting with google service account credentials, and will need to use them to generate docker creds. (Obviously we could still do this in the same script...)
Once I know exactly how different things will be I'll consider this, though.
bhearsum
force-pushed
the
push-lxqsunutrzow
branch
3 times, most recently
from
011e353 to
85f6369
Compare
This is to support the migration to Mozcloud. We'll do this in parallel with pushes to dockerhub to avoid one pipeline busting the other. I've dropped support for the archive tags here, because as far as I know we've never made use of them.
bhearsum
force-pushed
the
push-lxqsunutrzow
branch
from
85f6369 to
ec99c4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to support the migration to Mozcloud. We'll do this in parallel with pushes to dockerhub to avoid one pipeline busting the other.
I've dropped support for the archive tags here, because as far as I know we've never made use of them.