Support action as an attribution parameter (fixes mozilla-services#249) - #250
Open
lmegviar wants to merge 1 commit into
Open
Support action as an attribution parameter (fixes mozilla-services#249)#250lmegviar wants to merge 1 commit into
lmegviar wants to merge 1 commit into
Conversation
willdurand
reviewed
Jul 8, 2025
| ExpectedClientID: "", | ||
| ExpectedSessionID: "", | ||
| ExpectedClientIDGA4: "", | ||
| }, |
Member
There was a problem hiding this comment.
We'll want to have some assertion for action. I am thinking that we might want to introduce a new test function instead of adding even more params to this one.
Author
There was a problem hiding this comment.
I've updated in the patch - does that look more like what you were thinking?
Member
|
That looks promising, thanks! |
Author
|
Hi @willdurand, product has re-prioritized this work so I'm dusting off this patch and the corresponding changes in Firefox desktop. I noticed the action flag was being bound to the &dlsource variable instead of &action, so I've fixed that in addition to the testing updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.