Skip to content

bug(ios-rust): fix bad substitution in ios build script#7226

Merged
relud merged 1 commit intomainfrom
relud-bad-substituion
Feb 19, 2026
Merged

bug(ios-rust): fix bad substitution in ios build script#7226
relud merged 1 commit intomainfrom
relud-bad-substituion

Conversation

@relud
Copy link
Contributor

@relud relud commented Feb 18, 2026

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.


# Next, generate files with uniffi-bindgen (forward --generate-swift-sources if present)
# You generally want to generate the swift sources if you want to see/test the generated uniffi code
if (( ${#GENERATE_ARGS[@]:-0} )); then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is valid in the default version of bash installed on macos, but only because it's silently ignoring the :-0 part. in later versions of bash, it fails with a bad substitution error.

Also, this conditional is unnecessary, because "${GENERATE_ARGS[@]}" already does the right thing here. tested on bash 3.2.57 (mac os 26.2 default) and bash 5.3.9 (installed by homebrew).

@relud relud marked this pull request as ready for review February 18, 2026 21:57
@relud relud force-pushed the relud-bad-substituion branch from 2702758 to da973f2 Compare February 18, 2026 22:05
Copy link
Contributor

@skhamis skhamis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Looks good!

@relud relud added this pull request to the merge queue Feb 19, 2026
Merged via the queue into main with commit b70ea8c Feb 19, 2026
13 checks passed
@relud relud deleted the relud-bad-substituion branch February 19, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments