bug(ios-rust): fix bad substitution in ios build script#7226
Merged
Conversation
relud
commented
Feb 18, 2026
|
|
||
| # Next, generate files with uniffi-bindgen (forward --generate-swift-sources if present) | ||
| # You generally want to generate the swift sources if you want to see/test the generated uniffi code | ||
| if (( ${#GENERATE_ARGS[@]:-0} )); then |
Contributor
Author
There was a problem hiding this comment.
this is valid in the default version of bash installed on macos, but only because it's silently ignoring the :-0 part. in later versions of bash, it fails with a bad substitution error.
Also, this conditional is unnecessary, because "${GENERATE_ARGS[@]}" already does the right thing here. tested on bash 3.2.57 (mac os 26.2 default) and bash 5.3.9 (installed by homebrew).
2702758 to
da973f2
Compare
skhamis
approved these changes
Feb 18, 2026
Contributor
skhamis
left a comment
There was a problem hiding this comment.
Thanks for fixing this! Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
[ci full]to the PR title.