Open
Conversation
Imberflur
reviewed
Feb 5, 2023
| #[inline] | ||
| pub fn map_into<U, F>(orig: AtomicRef<'b, T>, f: F) -> MappedAtomicRef<'b, U> | ||
| where | ||
| F: FnOnce(&'b T) -> U, |
Contributor
There was a problem hiding this comment.
'b is the lifetime of the shared borrow of the AtomicRefCell (and not actually the lifetime that &T is valid for which is up until the AtomicRef/MappedAtomicRef is dropped).
Unfortunately, as noted here rust-lang/rust#70263 (comment), that means this API allows for UB.
E.g. the following test compiles:
#[test]
fn owned_map() {
use atomic_refcell::*;
let cell = AtomicRefCell::new(3u8);
let mut other = &mut 0u8;
let guard = AtomicRefMut::map_into(cell.borrow_mut(), |inner: &mut u8| {
// sneak reference out
other = inner;
});
// guard dropped but reference still accessible via `other`
drop(guard);
assert_eq!(*other, 3);
*cell.borrow_mut() = 1;
assert_eq!(*other, 1);
}There are some potential workarounds noted in the comment I linked, but they can make things difficult to work with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the functionality described here #11