Several AAudio fixes for issues on Firefox CI #833
Merged
+147
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible for the state_thread to run shutdown_with_error before the data callback has returned. stream_destroy ensures correct destruction anyway.
Per https://developer.android.com/ndk/reference/group/audio#group___audio_1ga60d7800abe432ad1e3404243c8407e1c, requestPause is not supported for input streams and will return ERROR_UNIMPLEMENTED. Use requestStop instead and adjust state transition expectations.
Pehrsons
requested changes
Jan 21, 2026
Contributor
Pehrsons
left a comment
Pehrsons
left a comment
There was a problem hiding this comment.
I have some reinit woes I'd like cleared before approving. The other commits look OK.
This makes stream_{start,stop} more predictable in the face of rapid start/stop
cycles.
kinetiknz
force-pushed
the
aaudio_timeout_fixes
branch
from
4fc91a4 to
705077d
Compare
Ensure reinit threads can't outlive their associated logical stream, and don't try to perform a reinit on a stream once it has been reallocated.
kinetiknz
force-pushed
the
aaudio_timeout_fixes
branch
from
705077d to
0b86c4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is working towards fixing the issues showing up in BMO 1988591 and related bugs. There's a few more fixes in the pipeline, but the set in this PR are small and quick to review.