style(avatar): oversizing of avatar on small screens#7051
style(avatar): oversizing of avatar on small screens#7051hritvi wants to merge 1 commit intomozilla:masterfrom
Conversation
|
@hritvi Looks fantastic! As the designer, I'm not sure if I should be approving the code here. @shane-tomlinson ? |
|
I can take a peek here! Edit: Hmm, actually maybe not. I don't have an iOS device, and I'm having trouble reproducing the original issue with a rotated photo. I'm not sure how the CSS here would address that - or how the original CSS would have caused it. I'm wondering if there's a further issue with how we're actually handling the image and any rotation info in EXIF data. (Kind of guessing here) |
|
Yeah, I think I'm super confused by this issue. I found a tall sample image with different EXIF data values and didn't see the squash or rotation from #5313. Also looks like things are a little off, at least where I'm trying it on Linux |
|
@lmorchard I think so the squash and rotation errors were resolved by some other PR as even I was unable to replicate that. There was another issue, that is #7045, which was closed as a dup of #5313 and it stated about the oversizing of profile images. |
|
Well, I didn't see the rotation & squash issues, but I did see an issue in this PR with the image being off-center in my screenshots. Not sure what might be causing that - maybe the |
|
This repo has been deprecated and migrated to https://github.com/mozill/fxa. Please open this PR against that repo. |
fixes #5313
It now looks like this on mobile view:

@ryanfeeley Please review.