Skip to content

Add a UI to undo cut/delete and cancel a copy (bug 2021352, bug 2010832)#20810

Merged
calixteman merged 1 commit intomozilla:masterfrom
calixteman:bug2010832
Mar 9, 2026
Merged

Add a UI to undo cut/delete and cancel a copy (bug 2021352, bug 2010832)#20810
calixteman merged 1 commit intomozilla:masterfrom
calixteman:bug2010832

Conversation

@calixteman
Copy link
Contributor

This happens in a bar on top of the thumbnails sidebar.
The label depending on the selected thumbnails is fixed.

@calixteman calixteman requested a review from timvandermeij March 5, 2026 15:53
@calixteman calixteman requested a review from a team as a code owner March 5, 2026 15:53
@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 17.24138% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.75%. Comparing base (46f4bc8) to head (0e48c16).

Files with missing lines Patch % Lines
src/display/display_utils.js 24.24% 25 Missing ⚠️
src/display/api.js 8.00% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20810      +/-   ##
==========================================
- Coverage   62.76%   62.75%   -0.01%     
==========================================
  Files         169      169              
  Lines      120419   120476      +57     
==========================================
+ Hits        75575    75606      +31     
- Misses      44844    44870      +26     
Flag Coverage Δ
fonttest 7.66% <ø> (ø)
unittestcli 62.72% <17.24%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@calixteman calixteman force-pushed the bug2010832 branch 2 times, most recently from 83d4b22 to 75ad4d2 Compare March 5, 2026 16:51
@timvandermeij
Copy link
Contributor

/botio-linux preview

@calixteman calixteman force-pushed the bug2010832 branch 2 times, most recently from ff9b4f4 to 40823f4 Compare March 5, 2026 22:35
@mozilla mozilla deleted a comment from moz-tools-bot Mar 7, 2026
@mozilla mozilla deleted a comment from moz-tools-bot Mar 7, 2026
@timvandermeij
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/04f3e170fb102a1/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/04f3e170fb102a1/output.txt

Total script time: 1.04 mins

Published

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comment addressed and passing integration tests. Looks good!

This happens in a bar on top of the thumbnails sidebar.
The label depending on the selected thumbnails is fixed.
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5a165285c93a1c0/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/dbab46e655d2dba/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/dbab46e655d2dba/output.txt

Total script time: 24.37 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/5a165285c93a1c0/output.txt

Total script time: 42.77 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 4ef5ea9 into mozilla:master Mar 9, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants