Add a new internal viewer to explore the structure of PDF files.#20831
Open
calixteman wants to merge 1 commit intomozilla:masterfrom
Open
Add a new internal viewer to explore the structure of PDF files.#20831calixteman wants to merge 1 commit intomozilla:masterfrom
calixteman wants to merge 1 commit intomozilla:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #20831 +/- ##
==========================================
- Coverage 62.71% 62.62% -0.09%
==========================================
Files 169 169
Lines 120476 120719 +243
==========================================
+ Hits 75553 75603 +50
- Misses 44923 45116 +193
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
calixteman
force-pushed
the
internal_viewer
branch
2 times, most recently
from
69bd754 to
b8adc52
Compare
calixteman
force-pushed
the
internal_viewer
branch
4 times, most recently
from
a36cf83 to
8b7a62f
Compare
The one from pdf.js.utils is a bit too old: a lot of bugs have been fixed in the code that parses PDF files since then. It's just an internal development tool, so it doesn't need to be perfect, but it should be good enough to be useful.
calixteman
force-pushed
the
internal_viewer
branch
from
8b7a62f to
9d81faf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The one from pdf.js.utils is a bit too old: a lot of bugs have been fixed in the code that parses PDF files since then.
It's just an internal development tool, so it doesn't need to be perfect, but it should be good enough to be useful.