Fix the disableFontFace and fontExtraProperties asserts in the FontFaceObject constructor (PR 20197 follow-up)#20836
Conversation
…ontFaceObject` constructor (PR 20197 follow-up) In PR 19548 these checks were added to ensure that the font-data sent from the worker-thread *always* include correct `disableFontFace` and `fontExtraProperties` data. For some reason PR 20197 then changed the code such that these checks became effectively pointless, since these properties are now checked after the fact *and* the new getters provide fallback values.
|
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6cac590b2f12504/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/f6938ac303cacd2/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/6cac590b2f12504/output.txt Total script time: 18.89 mins
Image differences available at: http://54.241.84.105:8877/6cac590b2f12504/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/f6938ac303cacd2/output.txt Total script time: 27.35 mins
Image differences available at: http://54.193.163.58:8877/f6938ac303cacd2/reftest-analyzer.html#web=eq.log |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20836 +/- ##
==========================================
+ Coverage 62.68% 62.76% +0.07%
==========================================
Files 169 169
Lines 120476 120479 +3
==========================================
+ Hits 75521 75613 +92
+ Misses 44955 44866 -89
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 participants
In PR #19548 these checks were added to ensure that the font-data sent from the worker-thread always include correct
disableFontFaceandfontExtraPropertiesdata.For some reason PR #20197 then changed the code such that these checks became effectively pointless, since these properties are now checked after the fact and the new getters provide fallback values.