Skip to content

Bug 2032246: Add cles statement to expanded row #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kala-moz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bug 2032246: Add cles statement to expanded row #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions src/__tests__/CompareResults/__snapshots__/ResultsView.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,35 @@ exports[`Results View Should display Base, New and Common graphs with replicates
</tbody>
</table>
</div>
<div
class="MuiPaper-root MuiPaper-elevation MuiPaper-rounded MuiPaper-elevation0 MuiAlert-root MuiAlert-colorInfo MuiAlert-standardInfo MuiAlert-standard css-st68mf-MuiPaper-root-MuiAlert-root"
role="alert"
style="--Paper-shadow: none;"
>
<div
class="MuiAlert-icon css-vab54s-MuiAlert-icon"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeInherit css-6gorna-MuiSvgIcon-root"
data-testid="InfoOutlinedIcon"
focusable="false"
viewBox="0 0 24 24"
>
<path
d="M11,9H13V7H11M12,20C7.59,20 4,16.41 4,12C4,7.59 7.59,4 12,4C16.41,4 20,7.59 20, 12C20,16.41 16.41,20 12,20M12,2A10,10 0 0,0 2,12A10,10 0 0,0 12,22A10,10 0 0,0 22,12A10, 10 0 0,0 12,2M11,17H13V11H11V17Z"
/>
</svg>
</div>
<div
class="MuiAlert-message css-zioonp-MuiAlert-message"
>
<strong>
Effect Size:
</strong>

</div>
</div>
</div>
</div>
</div>
Expand Down Expand Up @@ -533,6 +562,35 @@ exports[`Results View Should display Base, New and Common graphs with tooltips 1
</tbody>
</table>
</div>
<div
class="MuiPaper-root MuiPaper-elevation MuiPaper-rounded MuiPaper-elevation0 MuiAlert-root MuiAlert-colorInfo MuiAlert-standardInfo MuiAlert-standard css-st68mf-MuiPaper-root-MuiAlert-root"
role="alert"
style="--Paper-shadow: none;"
>
<div
class="MuiAlert-icon css-vab54s-MuiAlert-icon"
>
<svg
aria-hidden="true"
class="MuiSvgIcon-root MuiSvgIcon-fontSizeInherit css-6gorna-MuiSvgIcon-root"
data-testid="InfoOutlinedIcon"
focusable="false"
viewBox="0 0 24 24"
>
<path
d="M11,9H13V7H11M12,20C7.59,20 4,16.41 4,12C4,7.59 7.59,4 12,4C16.41,4 20,7.59 20, 12C20,16.41 16.41,20 12,20M12,2A10,10 0 0,0 2,12A10,10 0 0,0 12,22A10,10 0 0,0 22,12A10, 10 0 0,0 12,2M11,17H13V11H11V17Z"
/>
</svg>
</div>
<div
class="MuiAlert-message css-zioonp-MuiAlert-message"
>
<strong>
Effect Size:
</strong>

</div>
</div>
</div>
</div>
</div>
Expand Down
7 changes: 6 additions & 1 deletion src/common/testVersions/mannWhitney.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import KeyboardDoubleArrowUpIcon from '@mui/icons-material/KeyboardDoubleArrowUp
import ThumbDownIcon from '@mui/icons-material/ThumbDown';
import ThumbUpIcon from '@mui/icons-material/ThumbUp';
import WarningIcon from '@mui/icons-material/Warning';
import Alert from '@mui/material/Alert';
import Box from '@mui/material/Box';

import { MannWhitneyCompareMetrics } from '../../components/CompareResults/MannWhitneyCompareMetrics';
Expand Down Expand Up @@ -384,9 +385,10 @@ export const mannWhitneyStrategy = {

renderExpandedRight(result: CombinedResultsItemType) {
const mwResult = result as MannWhitneyResultsItem;
const { cles, cles_direction } = mwResult.cles ?? {
const { cles, cles_direction, mann_whitney_u_cles } = mwResult.cles ?? {
cles: '',
cles_direction: '',
mann_whitney_u_cles: '',
};
const { cliffs_delta, cliffs_interpretation } = mwResult;
const pValue = mwResult.mann_whitney_test?.pvalue;
Expand All @@ -404,6 +406,9 @@ export const mannWhitneyStrategy = {
cles={cles}
cles_direction={cles_direction}
/>
<Alert severity='info'>
<strong>Effect Size:</strong> {mann_whitney_u_cles}
</Alert>
<ModeInterpretation result={mwResult} />
</>
);
Expand Down