PCF-391 The keyboard handling for the revision dropdown should be done differently#926
Open
esanuandra wants to merge 7 commits intomozilla:mainfrom
Open
PCF-391 The keyboard handling for the revision dropdown should be done differently#926esanuandra wants to merge 7 commits intomozilla:mainfrom
esanuandra wants to merge 7 commits intomozilla:mainfrom
Conversation
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
esanuandra
force-pushed
the
keyboard-handling-for-revision-dropdown
branch
3 times, most recently
from
90de22d to
d5beba4
Compare
esanuandra
force-pushed
the
keyboard-handling-for-revision-dropdown
branch
from
d5beba4 to
d19522f
Compare
esanuandra
force-pushed
the
keyboard-handling-for-revision-dropdown
branch
6 times, most recently
from
fdde6ef to
54ddcf0
Compare
esanuandra
force-pushed
the
keyboard-handling-for-revision-dropdown
branch
5 times, most recently
from
b6922d9 to
031a978
Compare
esanuandra
force-pushed
the
keyboard-handling-for-revision-dropdown
branch
5 times, most recently
from
13e39ea to
7c2d3b9
Compare
Contributor
Author
|
I need some help with the Snackbar tests, fetchRevisionByID and fetchRevisionsBySearch. |
esanuandra
added
Ready For Review
and removed
🚧 WIP 🚧
esanuandra
force-pushed
the
keyboard-handling-for-revision-dropdown
branch
from
7c2d3b9 to
208f150
Compare
gmierz
reviewed
Nov 27, 2025
gmierz
reviewed
Nov 27, 2025
gmierz
reviewed
Nov 28, 2025
gmierz
reviewed
Nov 28, 2025
gmierz
reviewed
Nov 28, 2025
gmierz
reviewed
Nov 28, 2025
| } | ||
| } | ||
| }} | ||
| renderInput={renderInput} |
Contributor
There was a problem hiding this comment.
I'm not sure where this issue is coming from yet, but when I hit enter on a revision selection for the new one, the revision input field gets populated with the string of the revision that was selected. This is a bit annoying in combination with the issue above because if I want to select multiple revisions, I have to delete the revision input that was added, then I'm able to continue searching for more revisions to add.
kala-moz
requested changes
Dec 1, 2025
Contributor
kala-moz
left a comment
kala-moz
left a comment
There was a problem hiding this comment.
Added my comments and suggestions to the PR.
esanuandra
force-pushed
the
keyboard-handling-for-revision-dropdown
branch
from
208f150 to
0458490
Compare
esanuandra
force-pushed
the
keyboard-handling-for-revision-dropdown
branch
from
7785cde to
c80baad
Compare
esanuandra
force-pushed
the
keyboard-handling-for-revision-dropdown
branch
from
c80baad to
c2bde8b
Compare
kala-moz
requested changes
Apr 9, 2026
Contributor
kala-moz
left a comment
kala-moz
left a comment
There was a problem hiding this comment.
@esanuandra I left some suggestions on your tests to help you get them green.
Contributor
|
@esanuandra Looks like those three tests passed! Just need to update the snapshots. |
esanuandra
force-pushed
the
keyboard-handling-for-revision-dropdown
branch
from
249241b to
fc7ef71
Compare
esanuandra
force-pushed
the
keyboard-handling-for-revision-dropdown
branch
from
fc7ef71 to
1d0735d
Compare
esanuandra
force-pushed
the
keyboard-handling-for-revision-dropdown
branch
from
fcff5f2 to
406cedf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket - The keyboard handling for the revision dropdown should be done differently
This PR should make the navigation using the keyboard possible for searching revisions in Search component. Part of the implementation was made with the help of Cursor.