Reduce max table expiration days from 10,000 to 9,985

[sean-rose]

Tables can have a maximum of 10,000 partitions, but when partitions expire they apparently continue to count toward the table's partition quota for up to 14 days afterwards (7 days of time travel and 7 days of fail-safe), per the BigQuery docs:

When a partition expires, BigQuery deletes that partition. The partition data is retained in accordance with time travel and fail-safe policies, and can be charged for, depending on your billing model. Until then, the partition counts for purposes of table quotas.

And I subtracted one additional day just to make sure we don't hit the table partition limit.

[whd]

Academically this makes sense but as a practical matter I'm not sure it's worth landing this. If we do we should update https://github.com/mozilla-services/mozilla-pipeline-schemas/ as well to match.

[kwindau]

Don't see the harm in this, seems like a good idea

[sean-rose]

Academically this makes sense but as a practical matter I'm not sure it's worth landing this.

IMO if we're going to set an explicit upper limit it should be something that would actually work in practice, or we should not set the theoretical upper limit at all, but if the consensus is to leave it as is that's fine.

If we do we should update https://github.com/mozilla-services/mozilla-pipeline-schemas/ as well to match.

Thanks for catching this. I did file mozilla-services/mozilla-pipeline-schemas#833 in case we opt to proceed.

[whd]

Per slack discussion deferring decisions on this PR until meetings next week