Skip to content

fix(Readability): treat S and BDI as phrasing content #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 2 commits into
base: main
Choose a base branch
from
+38 −0
Open

fix(Readability): treat S and BDI as phrasing content #1011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
888a768
fix(Readability): treat S and BDI as phrasing content
SAY-5 May 19, 2026
ae4cfaf
Treat U as phrasing content and add test-page fixture for S, BDI, U
SAY-5 Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Readability.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ Readability.prototype = {
"ABBR",
"AUDIO",
"B",
"BDI",
"BDO",
"BR",
"BUTTON",
Expand All @@ -247,6 +248,7 @@ Readability.prototype = {
"PROGRESS",
"Q",
"RUBY",
"S",
"SAMP",
"SCRIPT",
"SELECT",
Expand All @@ -257,6 +259,7 @@ Readability.prototype = {
"SUP",
"TEXTAREA",
"TIME",
"U",
"VAR",
"WBR",
],
Expand Down
9 changes: 9 additions & 0 deletions test/test-pages/phrasing-elements-s-bdi-u/expected-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"title": "Phrasing elements test",
"byline": null,
"dir": null,
"excerpt": "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nunc mollis leo lacus,\n vitae semper nisl ullamcorper ut praesent in lectus eu\n nibh dapibus tincidunt. Vestibulum ante ipsum primis in faucibus orci luctus et\n ultrices posuere cubilia curae, donec pharetra libero nec massa ultricies, id\n fermentum arcu tincidunt. Curabitur sed dui vitae quam viverra sodales.",
"siteName": null,
"publishedTime": null,
"readerable": false
}
6 changes: 6 additions & 0 deletions test/test-pages/phrasing-elements-s-bdi-u/expected.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<div id="readability-page-1" class="page">
<div>
<p> Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nunc mollis leo lacus, <s>vitae</s> semper <bdi>nisl</bdi> ullamcorper <u>ut</u> praesent in lectus eu nibh dapibus tincidunt. Vestibulum ante ipsum primis in faucibus orci luctus et ultrices posuere cubilia curae, donec pharetra libero nec massa ultricies, id fermentum arcu tincidunt. Curabitur sed dui vitae quam viverra sodales. </p>
<p> Duis sagittis ipsum. Praesent mauris. Fusce nec tellus sed augue semper porta. Mauris massa. Vestibulum lacinia arcu eget nulla. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. </p>
</div>
</div>
20 changes: 20 additions & 0 deletions test/test-pages/phrasing-elements-s-bdi-u/source.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<!DOCTYPE html>
<html>
<head>
<title>Phrasing elements test</title>
</head>
<body>
<div>
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nunc mollis leo lacus,
<s>vitae</s> semper <bdi>nisl</bdi> ullamcorper <u>ut</u> praesent in lectus eu
nibh dapibus tincidunt. Vestibulum ante ipsum primis in faucibus orci luctus et
ultrices posuere cubilia curae, donec pharetra libero nec massa ultricies, id
fermentum arcu tincidunt. Curabitur sed dui vitae quam viverra sodales.
<div>
Duis sagittis ipsum. Praesent mauris. Fusce nec tellus sed augue semper porta.
Mauris massa. Vestibulum lacinia arcu eget nulla. Class aptent taciti sociosqu
ad litora torquent per conubia nostra, per inceptos himenaeos.
</div>
</div>
</body>
</html>