Add support for anonymous Azure blob access#2610
Open
agocke wants to merge 3 commits intomozilla:mainfrom
Open
Add support for anonymous Azure blob access#2610agocke wants to merge 3 commits intomozilla:mainfrom
agocke wants to merge 3 commits intomozilla:mainfrom
Conversation
The current support for Azure blob storage can't deal with the situation where the blob store needs to be accessed anonymously. This PR adds the opendal http backend and an environment variable that can be used to enable Azure anonymous access. If the environment variable is set, sccache falls back to direct http access instead of the opendal authentication flow.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2610 +/- ##
==========================================
- Coverage 72.74% 72.73% -0.01%
==========================================
Files 68 68
Lines 36985 37070 +85
==========================================
+ Hits 26903 26964 +61
- Misses 10082 10106 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
some jobs are failing |
Author
|
Thanks, investigating. |
Author
|
I believe this is ready for re review/testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current support for Azure blob storage can't deal with the situation where the blob store needs to be accessed anonymously. This PR adds the opendal http backend and an environment variable that can be used to enable Azure anonymous access. If the environment variable is set, sccache falls back to direct http access instead of the opendal authentication flow.