Skip to content

Bug 1885014 - The "Use replicates" button on the graph view never works the first time you click it #9445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidmiculit wants to merge 2 commits into
base: master
Choose a base branch
from
+26 −19
Open

Bug 1885014 - The "Use replicates" button on the graph view never works the first time you click it #9445

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7a559f
fix: make use replicates button work on first click and not force a p…
davidmiculit Apr 22, 2026
92405ec
fix: sync replicates ref before any fetches occur
davidmiculit Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 26 additions & 19 deletions ui/perfherder/graphs/GraphsView.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ function GraphsView({ projects, frameworks, user }) {
repository_name: repositoryName,
signature_id: signatureId,
framework_id: frameworkId,
replicates: seriesReplicates,
} = series;

return {
Expand All @@ -111,7 +110,7 @@ function GraphsView({ projects, frameworks, user }) {
framework: frameworkId,
interval: timeRangeRef.current.value,
all_data: true,
replicates: seriesReplicates,
replicates: replicatesRef.current,
};
}, []);

Expand Down Expand Up @@ -319,6 +318,10 @@ function GraphsView({ projects, frameworks, user }) {
);

const updateStateParams = useCallback((state) => {
const replicatesChanged =
state.replicates !== undefined &&
state.replicates !== replicatesRef.current;

if (state.testData !== undefined) setTestData(state.testData);
if (state.selectedDataPoint !== undefined)
setSelectedDataPoint(state.selectedDataPoint);
Expand All @@ -335,11 +338,24 @@ function GraphsView({ projects, frameworks, user }) {
setHighlightedRevisions(state.highlightedRevisions);
if (state.visibilityChanged !== undefined)
setVisibilityChanged(state.visibilityChanged);
if (state.replicates !== undefined) setReplicates(state.replicates);
if (state.colors !== undefined) setColors(state.colors);
if (state.symbols !== undefined) setSymbols(state.symbols);
pendingChangeParams.current = true;
}, []);

if (state.replicates !== undefined) {
setReplicates(state.replicates);
replicatesRef.current = state.replicates;
}

if (replicatesChanged) {
setZoom({});
setSelectedDataPoint(null);
setColors([...graphColors]);
setSymbols([...graphSymbols]);
getTestData();
} else {
pendingChangeParams.current = true;
}
}, [getTestData]);

// componentDidMount - check query params
useEffect(() => {
Expand All @@ -357,6 +373,11 @@ function GraphsView({ projects, frameworks, user }) {

const updates = {};

if (replicatesParam) {
updates.replicates = Boolean(parseInt(replicatesParam, 10));
replicatesRef.current = updates.replicates;
}

if (series) {
const _series = typeof series === 'string' ? [series] : series;
const seriesParams = parseSeriesParam(
Expand All @@ -380,9 +401,6 @@ function GraphsView({ projects, frameworks, user }) {
parseInt(hlInitialDataPoints, 10),
);
}
if (replicatesParam) {
updates.replicates = Boolean(parseInt(replicatesParam, 10));
}
if (hlRevisions) {
updates.highlightedRevisions =
typeof hlRevisions === 'string' ? [hlRevisions] : hlRevisions;
Expand Down Expand Up @@ -423,24 +441,13 @@ function GraphsView({ projects, frameworks, user }) {

if (prevSearch === location.search) return;

const { replicates: currentReplicates } = queryString.parse(
location.search,
);
const { replicates: prevReplicates } = queryString.parse(prevSearch);

if (
location.search === '' &&
testDataRef.current.length !== 0 &&
!loading
) {
setTestData([]);
}

if (prevReplicates !== undefined) {
if (currentReplicates !== prevReplicates) {
window.location.reload(false);
}
}
}, [location.search, loading]);

const handleUpdateTimeRange = useCallback(
Expand Down