Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions tests/etl/test_perf_data_load.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from treeherder.perf.models import (
MultiCommitDatum,
PerformanceDatum,
PerformanceDatumReplicate,
PerformanceFramework,
PerformanceSignature,
)
Expand Down Expand Up @@ -523,3 +524,21 @@ def test_multi_commit_data_is_removed_by_dedicated_management_script(
assert (
PerformanceDatum.objects.all().count() == DATA_PER_ARTIFACT
) # data ingested in the old way remains intact


def test_suite_replicates_are_ingested(test_repository, perf_job, sample_perf_artifact):
suite_replicates = [1.0, 2.0, 3.0]
sample_perf_artifact["blob"]["suites"][0]["replicates"] = suite_replicates
_, submit_datum = _prepare_test_data(sample_perf_artifact)

store_performance_artifact(perf_job, submit_datum)

suite_datum = PerformanceDatum.objects.get(
signature=PerformanceSignature.objects.get(suite="youtube-watch", test="")
)
stored_replicates = list(
PerformanceDatumReplicate.objects.filter(performance_datum=suite_datum).values_list(
"value", flat=True
)
)
assert sorted(stored_replicates) == sorted(suite_replicates)
17 changes: 17 additions & 0 deletions treeherder/etl/perf.py
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,23 @@ def _load_perf_datum(job: Job, perf_datum: dict):
# keep a register with all multi commit perf data
MultiCommitDatum.objects.create(perf_datum=suite_datum)

replicates = suite.get("replicates", [])
if replicates and len(replicates) > 0:
try:
# Add the replicates to the PerformanceDatumReplicate table, and
# catch and ignore any exceptions that are produced here so we don't
# impact the standard workflow
PerformanceDatumReplicate.objects.bulk_create(
[
PerformanceDatumReplicate(
value=replicate, performance_datum=suite_datum
)
for replicate in replicates
]
)
except Exception as e:
logger.info(f"Failed to ingest replicates for suite datum {suite_datum}: {e}")

if _suite_should_alert_based_on(signature, job, datum_created):
generate_alerts.apply_async(args=[signature.id], queue="generate_perf_alerts")

Expand Down