Show hours in artifact expiry instead of "expired" for sub-day expiries#9468
Open
fqueze wants to merge 1 commit intomozilla:masterfrom
Open
Show hours in artifact expiry instead of "expired" for sub-day expiries#9468fqueze wants to merge 1 commit intomozilla:masterfrom
fqueze wants to merge 1 commit intomozilla:masterfrom
Conversation
The live.log artifact of in-progress jobs has a short expiry and was being rendered as "expired" while the job was still running, which was misleading. The previous formatter floored the time-to-expiry to whole days, so anything under 24h became 0 and reported as expired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live.log artifact of in-progress jobs has a short expiry (typically a bit more than 2h) and was being rendered as "expired" while the job was still running, which was misleading. The previous formatter floored the time-to-expiry to whole days, so anything under 24h became 0 and reported as expired.