fix: validator test messages, Issue init-only fields, IssueEntity missing props, exception middleware, squad-ci wiring#29
Merged
mpaulosky merged 3 commits intoFeb 21, 2026
Conversation
…ssueRepository, exception middleware, squad-ci Co-authored-by: mpaulosky <60372079+mpaulosky@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor DTOs to records and finalize soft-delete audit trail
fix: validator test messages, Issue init-only fields, IssueEntity missing props, exception middleware, squad-ci wiring
Feb 21, 2026
8803035
into
feature/dto-refactor-and-soft-delete
0 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses remaining review feedback from PR #23 across five areas.
Changes
Validator tests: Fixed assertions to match actual FluentValidation messages (
"greater than or equal to 1"/"between 1 and 100"vs the incorrect"greater than 0")Issuerecord immutability: Soft-delete audit fields (IsArchived,ArchivedBy,ArchivedAt) changed from{ get; set; }to{ get; init; }, consistent with record semanticsIssueEntity/IssueRepository:ArchivedByandArchivedAtproperties toIssueEntity(previously referenced inToDomain()but undeclared — compilation error)Enum.Parse<IssueStatus>→Enum.TryParsewithignoreCase: trueandIssueStatus.Openfallback to avoid 500s on unexpected stored valuesException middleware: Added
UseExceptionHandlertoProgram.csmappingFluentValidation.ValidationException→ 400 with structured error body; previously these would surface as 500s despite endpoints declaring400squad-ci.yml: Replaced no-opechoplaceholder with actualdotnet restore / build / testpipeline💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.