Skip to content

[Sprint 21] Consolidate squad lint workflow filenames#453

Merged
mpaulosky merged 1 commit into
mainfrom
squad/452-consolidate-squad-lint-workflow-filenames
Jul 20, 2026
Merged

[Sprint 21] Consolidate squad lint workflow filenames#453
mpaulosky merged 1 commit into
mainfrom
squad/452-consolidate-squad-lint-workflow-filenames

Conversation

@mpaulosky

@mpaulosky mpaulosky commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Closes #452

Working as Boromir (DevOps / Infra)

Summary

  • Renamed lint workflow files to the standard squad-prefixed names
  • Removed superseded squad-standard-lint-* workflow definitions
  • Kept CI lint coverage intact while reducing duplicate workflow definitions

Validation

  • Pre-push gate passed locally (markdownlint, dotnet format, Release build)
  • Unit/architecture tests passed
  • Integration tests passed

Copilot AI review requested due to automatic review settings July 20, 2026 22:54
@github-actions

Copy link
Copy Markdown
Contributor

🏗️ PR Added to Squad Triage Queue

This PR has been labeled with squad and added to the triage queue.

Next steps:

  • The squad Lead will review and assign to an appropriate team member
  • A squad:member label will be added after triage

If you know which squad member should handle this, you can add the appropriate squad:member label yourself.

@github-actions github-actions Bot added the squad Squad triage inbox — Lead will assign to a member label Jul 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates GitHub Actions lint workflows by removing superseded squad-standard-lint-* definitions and relying on the existing squad-lint-* workflows to keep markdown/YAML linting consistent and non-duplicative.

Changes:

  • Deleted the superseded squad-standard-lint-markdown.yml and squad-standard-lint-yaml.yml workflows to eliminate duplication.
  • Updated squad-lint-markdown.yml and squad-lint-yaml.yml workflow triggers (and markdownlint globs) as part of the consolidation.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/workflows/squad-standard-lint-yaml.yml Removed duplicate YAML lint workflow definition.
.github/workflows/squad-standard-lint-markdown.yml Removed duplicate Markdown lint workflow definition.
.github/workflows/squad-lint-yaml.yml Adjusted YAML lint workflow trigger branches while keeping yamllint job.
.github/workflows/squad-lint-markdown.yml Adjusted Markdown lint workflow trigger branches and updated markdownlint globs.
Comments suppressed due to low confidence (4)

.github/workflows/squad-lint-yaml.yml:6

  • The push trigger was changed from dev/insider to dev/release. This drops YAML lint coverage on the insider branch and (combined with the pull_request change below) may also reduce coverage on main, contradicting the PR/issue goal of keeping lint coverage intact. If release is intended, consider adding it rather than replacing existing branches.
    .github/workflows/squad-lint-yaml.yml:9
  • The PR trigger was narrowed to dev/release, which means YAML lint will no longer run for PRs targeting main (and previously preview/insider). This appears to conflict with the stated intent to keep CI lint coverage intact when removing the superseded workflows.
    .github/workflows/squad-lint-markdown.yml:6
  • The push trigger was changed from dev/insider to dev/release. This drops markdown lint coverage on the insider branch and may be unintended given the issue scope focused on consolidating filenames while keeping coverage.
    .github/workflows/squad-lint-markdown.yml:8
  • The PR trigger was narrowed to dev/release, which stops markdown lint from running on PRs targeting main (and previously preview/insider). This seems at odds with the PR description’s claim that lint coverage is kept intact after removing the old workflows.

@github-actions

Copy link
Copy Markdown
Contributor

Test Results Summary

556 tests  ±0   518 ✅ ±0   13s ⏱️ -1s
  6 suites ±0    38 💤 ±0 
  6 files   ±0     0 ❌ ±0 

Results for commit 0a8827e. ± Comparison against base commit 684d939.

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.78%. Comparing base (684d939) to head (0a8827e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #453   +/-   ##
=======================================
  Coverage   76.78%   76.78%           
=======================================
  Files          71       71           
  Lines        1775     1775           
  Branches      214      214           
=======================================
  Hits         1363     1363           
  Misses        336      336           
  Partials       76       76           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mpaulosky
mpaulosky merged commit 4e0ca52 into main Jul 20, 2026
18 of 19 checks passed
@mpaulosky
mpaulosky deleted the squad/452-consolidate-squad-lint-workflow-filenames branch July 20, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

squad Squad triage inbox — Lead will assign to a member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Sprint 21] Consolidate squad lint workflow filenames

2 participants