[Sprint 21] Consolidate squad lint workflow filenames#453
Merged
mpaulosky merged 1 commit intoJul 20, 2026
Conversation
Contributor
🏗️ PR Added to Squad Triage QueueThis PR has been labeled with Next steps:
|
There was a problem hiding this comment.
Pull request overview
This PR consolidates GitHub Actions lint workflows by removing superseded squad-standard-lint-* definitions and relying on the existing squad-lint-* workflows to keep markdown/YAML linting consistent and non-duplicative.
Changes:
- Deleted the superseded
squad-standard-lint-markdown.ymlandsquad-standard-lint-yaml.ymlworkflows to eliminate duplication. - Updated
squad-lint-markdown.ymlandsquad-lint-yaml.ymlworkflow triggers (and markdownlint globs) as part of the consolidation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/squad-standard-lint-yaml.yml | Removed duplicate YAML lint workflow definition. |
| .github/workflows/squad-standard-lint-markdown.yml | Removed duplicate Markdown lint workflow definition. |
| .github/workflows/squad-lint-yaml.yml | Adjusted YAML lint workflow trigger branches while keeping yamllint job. |
| .github/workflows/squad-lint-markdown.yml | Adjusted Markdown lint workflow trigger branches and updated markdownlint globs. |
Comments suppressed due to low confidence (4)
.github/workflows/squad-lint-yaml.yml:6
- The push trigger was changed from
dev/insidertodev/release. This drops YAML lint coverage on theinsiderbranch and (combined with the pull_request change below) may also reduce coverage onmain, contradicting the PR/issue goal of keeping lint coverage intact. Ifreleaseis intended, consider adding it rather than replacing existing branches.
.github/workflows/squad-lint-yaml.yml:9 - The PR trigger was narrowed to
dev/release, which means YAML lint will no longer run for PRs targetingmain(and previouslypreview/insider). This appears to conflict with the stated intent to keep CI lint coverage intact when removing the superseded workflows.
.github/workflows/squad-lint-markdown.yml:6 - The push trigger was changed from
dev/insidertodev/release. This drops markdown lint coverage on theinsiderbranch and may be unintended given the issue scope focused on consolidating filenames while keeping coverage.
.github/workflows/squad-lint-markdown.yml:8 - The PR trigger was narrowed to
dev/release, which stops markdown lint from running on PRs targetingmain(and previouslypreview/insider). This seems at odds with the PR description’s claim that lint coverage is kept intact after removing the old workflows.
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
=======================================
Coverage 76.78% 76.78%
=======================================
Files 71 71
Lines 1775 1775
Branches 214 214
=======================================
Hits 1363 1363
Misses 336 336
Partials 76 76 🚀 New features to boost your workflow:
|
mpaulosky
deleted the
squad/452-consolidate-squad-lint-workflow-filenames
branch
July 20, 2026 22:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #452
Working as Boromir (DevOps / Infra)
Summary
Validation