Open
Conversation
526b576 to
bc43191
Compare
Collaborator
Author
|
It seems like an improved version of this PR was already pushed in as PR #313:
Review this later, and probably close the PR without committing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tests the use of
MPI_Allreduce_reproducible(). This Allreduce is reproducible (even for the lowest bit), by doing a Gatther to a single rank, and then callingMPI_Reduce_local(tmpbuf, recvbuf, count, datatype, op);to do theopreproducibly on the local process.@tarunsmalviya, please cherry-pick the top commit, 'allreduce-reproducible', from my allreduce-reproducible branch and test this, to see if the resume and restart branch agree with each other:
I'm hoping that the resume and the restart will match each other after this.