Fixed: mmap wrapper may overwrite memory segment#471
Open
xuyao0127 wants to merge 1 commit intompickpt:mainfrom
Open
Fixed: mmap wrapper may overwrite memory segment#471xuyao0127 wants to merge 1 commit intompickpt:mainfrom
xuyao0127 wants to merge 1 commit intompickpt:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided to use regular mmap (without MAP_FIXED or MAP_FIXED_NOREPLACE) when allocating memory in the mmap wrapper. This allows the kernel to avoid existing memory segments.
We still need some improvement regarding the memory management and mmap wrapper design for the upper-half. Maybe we can read the proc map file to dynamically decide what memory segments are available for the upper-half.