ci: add reproducible plugin verification - #1
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
📝 WalkthroughWalkthroughThe pull request pins the Rust/WASM toolchain, makes WASM tests fail when artifacts are missing, adds smoke coverage for runtime exports, updates test documentation, and introduces conditional reusable workflows for plugin CI and tagged releases. ChangesWASM validation and plugin delivery
Estimated code review effort: 2 (Simple) | ~15 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/wasm_smoke.rs (1)
21-29: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winExtract duplicated
wasm_path()/require_wasm!into a shared test helper.Both files carry an identical artifact-path helper and now-trivial macro; a shared
tests/common/mod.rs(or similar) would avoid future drift between the two copies.
tests/wasm_smoke.rs#L21-L29: movewasm_path()(and therequire_wasm!macro at L53-L57) into a shared test helper module andinclude!/mod-import it here.tests/folder_e2e.rs#L20-L28: remove the duplicatewasm_path()/require_wasm!(L111-L115) and import the same shared helper.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/wasm_smoke.rs` around lines 21 - 29, The duplicated wasm_path() helper and require_wasm! macro should be centralized in a shared tests/common/mod.rs (or equivalent) module. Move both definitions from tests/wasm_smoke.rs#L21-L29 and its macro at L53-L57 into the shared helper, then import that module in tests/wasm_smoke.rs. Remove the duplicate definitions from tests/folder_e2e.rs#L20-L28 and its macro at L111-L115, and import the same shared helper there.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/wasm_smoke.rs`:
- Around line 21-29: The duplicated wasm_path() helper and require_wasm! macro
should be centralized in a shared tests/common/mod.rs (or equivalent) module.
Move both definitions from tests/wasm_smoke.rs#L21-L29 and its macro at L53-L57
into the shared helper, then import that module in tests/wasm_smoke.rs. Remove
the duplicate definitions from tests/folder_e2e.rs#L20-L28 and its macro at
L111-L115, and import the same shared helper there.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2137ccb4-4d9e-4a93-aa97-bdee4ff884d1
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (7)
.github/workflows/plugin-ci.yml.gitignoreCargo.tomlREADME.mdrust-toolchain.tomltests/folder_e2e.rstests/wasm_smoke.rs
💤 Files with no reviewable changes (1)
- .gitignore
Summary
Validation
Linear: MAT-129
Summary by cubic
Adds reproducible plugin CI with scoped permissions and owner-only releases. Makes WASM smoke tests mandatory and fully exercises extraction and resolution via the
http_requestboundary; fulfills Linear MAT-129.New Features
v*tags (write); pinned (repinned) to canonical workflows by SHA; restrict releases to the repository owner.Cargo.lock; pin Rust1.95.0and targetwasm32-wasip1viarust-toolchain.toml.Dependencies
extismto=1.30.0.Written for commit ad0b00c. Summary will update on new commits.
Summary by CodeRabbit
New Features
Tests
Documentation
Chores