feat: adopt typed yt-dlp broker and reproducible CI - #5
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
📝 WalkthroughWalkthroughThe plugin version is updated to 1.3.0 and requires Vortex 0.2.0. Download execution now uses the typed ChangesTyped yt-dlp broker migration
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant WASMSmokeTest
participant PluginAPI
participant HostStubs
WASMSmokeTest->>PluginAPI: invoke download_to_file
PluginAPI->>HostStubs: run_ytdlp(request JSON)
HostStubs-->>PluginAPI: response JSON with exit_code and stdout
PluginAPI-->>WASMSmokeTest: downloaded path
WASMSmokeTest->>HostStubs: inspect captured request
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
All reported issues were addressed across 10 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Summary
Validation
Linear: MAT-129, MAT-131
Summary by cubic
Switch downloads to the typed
run_ytdlpbroker and harden reproducible CI with split verify/release workflows repinned to canonical upstream SHAs, gated by tags, and restricted to the repository owner. Bumps the plugin to 1.3.0, requires Vortex host 0.2.0, and adds a release WASM ABI smoke test (addresses Linear MAT-129, MAT-131).New Features
run_ytdlpbroker: replacerun_subprocess, send only url/format/output_dir/audio_only, and parse the typed response.tests/wasm_smoke.rsto validate exports and the broker contract end-to-end.extismto=1.30.0.Migration
run_ytdlpfunction (Vortex ≥ 0.2.0) andsubprocess: ["yt-dlp"]capability.Written for commit 6e5ca16. Summary will update on new commits.
Summary by CodeRabbit