chore(ci): ignore quick-xml advisories in cargo audit config (MAT-139)#180
Conversation
RUSTSEC-2026-0194/0195 fire on quick-xml 0.39.4, reachable only through the wayland-scanner build-time proc-macro (trusted protocol XML, never in the shipped binary). The bump to quick-xml 0.41 is merged upstream (Smithay/wayland-rs d07c4f91f2) but not released, so cargo update can't purge it yet. Mirror the existing deny.toml triage in .cargo/audit.toml so local cargo audit runs stay actionable. Remove both entries once wayland-scanner > 0.31.10 ships. Refs MAT-139
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
📝 WalkthroughWalkthroughCargo audit now ignores two RustSec advisories associated with ChangesRepository maintenance
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Around line 12-16: Update the changelog entry describing the cargo audit
exception to include the concrete review date 2026-10-15, while preserving the
existing context about the ignored advisories and upstream fix.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: adf0ff9a-84ce-4389-8d17-a59bfc328d14
📒 Files selected for processing (2)
.cargo/audit.tomlCHANGELOG.md
There was a problem hiding this comment.
cubic analysis
No issues found across 2 files
Linked issue analysis
Linked issue: MAT-139: Suivre les advisories quick-xml 0.39 (RUSTSEC-2026-0194/0195) via wayland-scanner
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Add RUSTSEC-2026-0194 and RUSTSEC-2026-0195 to .cargo/audit.toml ignore list | The diff of .cargo/audit.toml shows the two IDs were added to the ignore array. |
| ✅ | Document rationale, tracking (MAT-139) and temporary removal condition / review date in the audit config | The added comment explains the build-time proc-macro context, references MAT-139, states to remove after cargo update once wayland-scanner > 0.31.10 ships, and includes a review date (2026-10-15). |
| ✅ | Ensure cargo audit exits successfully (no blocking advisories) when run against src-tauri/Cargo.lock | PR verification states `cargo audit -f src-tauri/Cargo.lock` exits 0 (previously showed 2 vulnerabilities). The PR's change is the cause of the green audit run. |
| ✅ | Record the change in CHANGELOG | CHANGELOG.md was updated with a Security section noting the temporary ignore and tracking MAT-139. |
actions/first-interaction v3 reads issue_message and pr_message with required: true at runtime even though action.yml declares neither as required. The split welcome-pr/welcome-issue jobs each passed only one message, so every first-time PR (and, next time, issue) crashed with 'Input required and not supplied'. Merge them into a single job that handles both events and supplies both messages.
Quoi
Ajoute RUSTSEC-2026-0194 et RUSTSEC-2026-0195 (quick-xml 0.39.4) à la liste d'ignore de
.cargo/audit.toml, avec commentaire, condition de retrait et date de revue (2026-10-15, alignée surdeny.toml).Pourquoi
Les deux advisories ne sont atteignables que via
wayland-scanner0.31.10, un proc-macro de build qui parse du XML de protocole Wayland embarqué — entrée de confiance, absente du binaire livré (triage complet dans MAT-139). Le chemin runtime utilise déjà quick-xml 0.41.0 patché.Le bump vers quick-xml 0.41 est mergé upstream (Smithay/wayland-rs
d07c4f91f2, 2026-07-02) mais pas encore publié : la dernière release crates.io (0.31.10) pin^0.39, donccargo updatene peut pas purger l'advisory aujourd'hui.deny.toml(le gate CI) ignore déjà ces IDs ; ce PR aligne la configcargo auditlocale pour que ses runs restent actionnables.L'ignore est temporaire : à retirer via
cargo updatedès que wayland-scanner > 0.31.10 sort.Vérification
cargo audit -f src-tauri/Cargo.lockdepuis la racine : exit 0, plus que des warnings autorisés (avant : 2 vulnérabilités)cargo deny --manifest-path src-tauri/Cargo.toml check:advisories ok, bans ok, licenses ok, sources ok(inchangé)Refs MAT-139
Summary by cubic
Ignore
RUSTSEC-2026-0194/0195forquick-xml 0.39.4in.cargo/audit.toml(build-time viawayland-scanner), with a 2026-10-15 review and removal note, matchingdeny.tomlper MAT-139, untilwayland-scannerships a release usingquick-xml >= 0.41. Also fixes the first-time contributor workflow by merging the welcome jobs and supplying both messages.actions/first-interactionv3 needs bothissue_messageandpr_message; combined PR/issue welcomes into one job to prevent “Input required and not supplied” failures.Written for commit d87e581. Summary will update on new commits.
Summary by CodeRabbit
Security
Fixed