FIX: Replace deprecated np.object with builtin object#21
Open
AMAN194701 wants to merge 1 commit intompl-extensions:mainfrom
Open
FIX: Replace deprecated np.object with builtin object#21AMAN194701 wants to merge 1 commit intompl-extensions:mainfrom
AMAN194701 wants to merge 1 commit intompl-extensions:mainfrom
Conversation
Author
|
Hi maintainers, Both issues reproduce on the current main branch without my changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
np.object was removed in NumPy 1.24. This causes an AttributeError
on any modern NumPy installation, making mpl-playback completely
broken out of the box.
Fix
Replace np.object with the builtin object in two places:
Tested on