Rewrites osxtools.py and dylib_unhell.py in a single Swift script. - #18276
Rewrites osxtools.py and dylib_unhell.py in a single Swift script. #18276pxia wants to merge 4 commits into
Conversation
So it no longer depends on library install path. Some users (like me) have custom homebrew prefix that the old way might cause libraries to be incorrectly skipped.
|
Anyone can review this? |
|
just be patient. it would probably be a good idea to make this more incremental if this is supposed to be an exact port. for now leave the improvements out. |
|
btw. What's wrong with python version? I don't see how swift version simplifies the workflow. |
|
I don't know either... I just want to make the isUserLib change (2nd commit) and it intersects with the item on #13608. |
it's similar to the arguments brought up for the obj-c to swift transition. some of it is my personal preference, since i also maintain that code. though the plan was to use (swift) native APIs to replace the usage of (some) CLI commands and the manual parsing of those outputs. in the best case this should be cleaner and faster. for now i only have some local tests, though.
feel free to fix those in the current script and make a separate PR. |
3 participants
As the title suggests. I saw this is an open item in the "Want to work on mpv" post so here it is. Also made a small improvement in the dylib finding function.
Tested on macos 15, 26, and 27 beta.