vo_gpu: interpolation-threshold deactivate on any integer ratio - #18341
Open
spaceoden wants to merge 1 commit into
Open
vo_gpu: interpolation-threshold deactivate on any integer ratio#18341spaceoden wants to merge 1 commit into
spaceoden wants to merge 1 commit into
Conversation
Instead of checking whether the ideal_frame_duration to vsync_interval ratio is approximately 1.0, check whether the ratio is approximately an integer. This way, any video whose fps is approximately a factor of the display Hz will pass the check.
kasper93
reviewed
Aug 4, 2026
| if (interpolate) { | ||
| double ratio = frame->ideal_frame_duration / frame->vsync_interval; | ||
| if (fabs(ratio - 1.0) < p->opts.interpolation_threshold) | ||
| if (fabs(ratio - floor(ratio + 0.5)) < p->opts.interpolation_threshold) |
Member
There was a problem hiding this comment.
If we are redrawing frame, it will be interpolated depending on tscale for each vsync, between frame points. This change would disable that, which is core interpolation logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of checking whether the ideal_frame_duration to vsync_interval ratio is approximately 1.0, check whether the ratio is approximately an integer (by comparing the ratio to itself rounded). This way, any video whose fps is approximately a factor of the display Hz will pass the check.