Turn role errors into warnings#1
Open
dominiquedevriese wants to merge 3 commits into
Open
Conversation
experimentation in cases where inferred roles are wrong.
Also: add a -Wdictionary-application-roles flag that is by default on, which can be turned off by -Wno-dictionary-application-roles. It can also be turned into an error by -Werror=dictionary-application-roles This is useful because current role inference in GHC is imperfect (no higher-order roles).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thomas,
Deze PR in je GHC branch een wijziging gemaakt om van de role errors warnings te maken.
Er zijn namelijk nogal wat gevallen waar rollen slecht geïnfereerd worden, vaak omwille van het gebrek aan higher-order rollen.
Een student die zijn bachelorthesis bij mij maakt heeft dit nodig om bijvoorbeeld MonadWriter dictionaries te kunnen instantiëren.
groetjes
Dominique