feat(cast): add Google Cast support and :output command#40
Open
oca-agent wants to merge 8 commits into
Open
Conversation
Owner
|
This should use the latest version of SharpCaster. |
mrazza
reviewed
May 15, 2026
| public PlaybackState PlaybackState => _state; | ||
| public Song Song => _song; | ||
|
|
||
| public async void Play() { |
Owner
There was a problem hiding this comment.
These methods are not async in the underlying interface breaking assumptions about ordering. Functions where we call Stop() then Play() may execute in the wrong order.
mrazza
requested changes
May 16, 2026
Owner
mrazza
left a comment
There was a problem hiding this comment.
XML doc comments are required on all public classes and public methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Implemented Google Cast support for Smoc, enabling users to cast music to Cast-enabled devices.
Core Features
CastDiscoveryServiceto discover Chromecast devices on the local network using mDNS viaChromecastLocator.CastAudioServiceandCastPlaybackServiceto control playback on remote devices.IChromecastClientandChromecastClientWrapperto allow for robust unit testing of Cast services via mocking.StreamingProxyServiceto bridge Smoc's internal audio streams to Chromecast using a local HTTP listener.:outputcommand to switch between local and remote playback.:output [tab]).Technical Details
Sharpcaster.Models.Media.MediaStatusupdates and map them to Smoc's internalPlaybackState.StandardPlaybackQueueServiceto support dynamic audio service switching without losing queue state.CommandServicewith a plugin-based completion architecture.Test Coverage
Added unit tests for all major new components:
StreamingProxyServiceTest: Verifies the local HTTP streaming proxy functionality.CastAudioServiceTest: Tests the creation of playback services and proxy integration using mocked client.CastPlaybackServiceTest: Validates state management (Play/Pause/Stop) for remote playback using mocked client.CommandServiceTest: Added coverage for the new tab-completion logic.CommandLineTest: Verified UI-level tab-completion handling.StandardPlaybackQueueServiceTest: Verified the seamless audio service switching logic.Resolves #39