feat: replace build scripts with Makefile with support of fpm-based .deb packaging#52
Open
bowling233 wants to merge 1 commit intomrhaoxx:mainfrom
Open
feat: replace build scripts with Makefile with support of fpm-based .deb packaging#52bowling233 wants to merge 1 commit intomrhaoxx:mainfrom
bowling233 wants to merge 1 commit intomrhaoxx:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Debian packaging support for Netgate/OpenNG using fpm, including a build script and a systemd unit to run the installed binary.
Changes:
- Added
build-deb.shto build the UI + Go binary and produce an.deb. - Added
.fpmoptions file and a new packaged systemd unit (packaging/netgate.service). - Updated
.gitignoreand adjustedui/html/package-lock.jsonmetadata.
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/html/package-lock.json | Lockfile metadata changes (removal of some peer markers). |
| packaging/netgate.service | New systemd unit intended for packaged installs. |
| build-deb.sh | New build-and-package script producing netgate_<version>_amd64.deb. |
| .gitignore | Ignores build artifacts: binary and .deb outputs. |
| .fpm | Defines fpm package metadata and file mappings (config + service unit). |
Files not reviewed (1)
- ui/html/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Consolidate build.sh and build-deb.sh into a single Makefile with multi-arch support. Targets include linux-amd64, linux-arm64 (binary builds), deb-amd64, deb-arm64 (.deb packages), ui (frontend), and clean. fpm metadata and file mappings are centralized in .fpm. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bowling233
changed the title
Author
|
Fixed suggestions from Copilot and refined Makefile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate build.sh and build-deb.sh into a single Makefile with
multi-arch support. Targets include linux-amd64, linux-arm64 (binary
builds), deb-amd64, deb-arm64 (.deb packages), ui (frontend), and
clean. fpm metadata and file mappings are centralized in .fpm.