Skip to content

JavaScript: Reduce FPs in missing-regexp-anchor for intentional partial matching #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mrigankpawagi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

JavaScript: Reduce FPs in missing-regexp-anchor for intentional partial matching #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions javascript/ql/src/Security/CWE-020/MissingRegExpAnchor.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,23 @@ import MissingRegExpAnchor::Make<TreeImpl, HostnameRegexp::Impl, Impl>

from DataFlow::Node nd, string msg
where
isUnanchoredHostnameRegExp(nd, msg)
or
isSemiAnchoredHostnameRegExp(nd, msg)
or
hasMisleadingAnchorPrecedence(nd, msg)
// isLineAnchoredHostnameRegExp is not used here, as it is not relevant to JS.
(
isUnanchoredHostnameRegExp(nd, msg)
or
isSemiAnchoredHostnameRegExp(nd, msg)
or
hasMisleadingAnchorPrecedence(nd, msg)
) and
// Exclude patterns used with .test() where unanchored alternatives are simple words
// (no dots), indicating intentional partial matching for role/type checks, not URL validation
not exists(DataFlow::MethodCallNode testCall |
testCall.getMethodName() = "test" and
nd.(DataFlow::RegExpCreationNode).getARegExpObject().flowsTo(testCall.getReceiver()) and
forall(RegExpTerm alt |
alt = nd.(DataFlow::RegExpCreationNode).getRoot().(RegExpAlt).getAChild() and
not alt.getAChild*() instanceof RegExpAnchor
|
not alt.getAChild*().(RegExpConstant).getValue().matches("%.%")
)
)
select nd, msg
10 changes: 10 additions & 0 deletions javascript/ql/test/query-tests/Security/CWE-020/MissingRegExpAnchor/tst-intentional-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
(function() {
// GOOD: simple word alternation used with .test() for role checking
// These are intentional partial matches, not URL validation
var rolePattern = /^admin|user|guest/;
if (rolePattern.test(role)) { /* ... */ }

// BAD: hostname pattern with misleading anchor precedence
var urlCheck = /^https?:\/\/good.com|https?:\/\/evil.com/; // $ Alert
if (urlCheck.test(url)) { /* ... */ }
});
Loading