Skip to content

chore: add static checks workflow for #320 phase C#325

Merged
mrlunchbox777 merged 12 commits into
mainfrom
feature/code-scanning-transition-320
May 3, 2026
Merged

chore: add static checks workflow for #320 phase C#325
mrlunchbox777 merged 12 commits into
mainfrom
feature/code-scanning-transition-320

Conversation

@mrlunchbox777

@mrlunchbox777 mrlunchbox777 commented Apr 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • add .github/workflows/static-checks.yaml to run shellcheck, shfmt -d, and actionlint in CI
  • update pivot: decommission bsctl Go CLI and retire CodeQL #320 decommission planning doc with Phase C status and immediate static-check stabilization steps
  • docs bump to 0.1.26 in resources/version.yaml, mirrored bsctl/static/resources/constants.yaml, and new CHANGELOG.md entry

Validation

  • ran ./scripts/workflows/docs-bump_docs-bump_version-bump.sh
  • ran ./scripts/workflows/docs-bump_docs-bump_CHANGELOG-bump.sh

Issue Link

@github-actions github-actions Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. changes/documentation Documentation file changes changes/root Root file changes changes/meta .github file changes changes/resources Resources file changes and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 9, 2026
@mrlunchbox777 mrlunchbox777 added kind/chore Chore to be completed, e.g. renovate priority/4 Lower priority status/review Ready for review labels Apr 9, 2026
@mrlunchbox777

Copy link
Copy Markdown
Owner Author

Phase C PR is ready for review and labels are synced with issue #320.

  • Added CI static-check scaffolding workflow (shellcheck, shfmt -d, actionlint).
  • Docs/version bump included (0.1.23).
  • Managed labels synchronized on issue/PR and status set to status/review.

@mrlunchbox777 mrlunchbox777 linked an issue Apr 9, 2026 that may be closed by this pull request
7 tasks
@mrlunchbox777 mrlunchbox777 requested a review from Copilot April 9, 2026 04:16
@github-actions github-actions Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds CI static analysis for shell scripts and GitHub Actions workflows as part of the Phase C transition plan in #320, while bumping versioning/docs to reflect the new milestone.

Changes:

  • Added a new CI workflow to run shellcheck, shfmt -d, and actionlint on relevant changes.
  • Updated the bsctl/CodeQL decommission planning doc with Phase C status and next steps.
  • Bumped version to 0.1.23 and added a corresponding CHANGELOG.md entry (including legacy mirror update).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.github/workflows/static-checks.yaml Introduces CI jobs for shell/workflow static checks to replace Go-focused scanning over time.
docs/plans/bsctl-codeql-decommission-plan.md Records Phase C status and refines immediate next steps around static-check stabilization.
resources/version.yaml Updates the primary repo version source to 0.1.23.
bsctl/static/resources/constants.yaml Mirrors the version bump to 0.1.23 for legacy transition compatibility.
CHANGELOG.md Adds a 0.1.23 entry documenting the workflow/doc updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/static-checks.yaml
Comment thread .github/workflows/static-checks.yaml Outdated
@github-actions github-actions Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 9, 2026
@mrlunchbox777 mrlunchbox777 requested a review from Copilot April 9, 2026 04:25

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread resources/version.yaml Outdated
Comment thread CHANGELOG.md

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/static-checks.yaml Outdated
Comment thread .github/workflows/static-checks.yaml Outdated
Comment thread .github/workflows/static-checks.yaml Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/static-checks.yaml Outdated
@mrlunchbox777 mrlunchbox777 force-pushed the feature/code-scanning-transition-320 branch from 69d41a9 to 5ef8d8e Compare May 3, 2026 05:09
@mrlunchbox777 mrlunchbox777 requested a review from Copilot May 3, 2026 05:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .agents/README.md Outdated
Comment thread CHANGELOG.md
Comment thread .github/workflows/static-checks.yaml Outdated
Comment thread .github/workflows/static-checks.yaml Outdated
Signed-off-by: Andrew Shoell <mrlunchbox777@gmail.com>
Signed-off-by: Andrew Shoell <mrlunchbox777@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/static-checks.yaml Outdated
Comment thread .github/workflows/static-checks.yaml Outdated
Signed-off-by: Andrew Shoell <mrlunchbox777@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/static-checks.yaml Outdated
Comment thread .github/workflows/static-checks.yaml
Signed-off-by: Andrew Shoell <mrlunchbox777@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/static-checks.yaml
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Shoell <mrlunchbox777@gmail.com>
@mrlunchbox777 mrlunchbox777 merged commit 817a4a7 into main May 3, 2026
9 checks passed
@mrlunchbox777 mrlunchbox777 deleted the feature/code-scanning-transition-320 branch May 3, 2026 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes/documentation Documentation file changes changes/meta .github file changes changes/resources Resources file changes changes/root Root file changes kind/chore Chore to be completed, e.g. renovate priority/4 Lower priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/review Ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pivot: decommission bsctl Go CLI and retire CodeQL

2 participants