feat: Offer the Frame TV panel size as a crop preset - #82
Merged
Conversation
Owner
|
@SirTerrific Hey, there are some merge conflicts (I already merged a PR that also contains a version of the get device endpoint :) ) |
A Frame TV reports `resolution_type: UHD`, so 3840x2160 is the crop that fills the panel without the set rescaling the image. It was not among the presets, leaving 1920x1080 as the closest fit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
SirTerrific
force-pushed
the
pr-tv-info-4k
branch
from
August 12, 2026 23:15
6a890f2 to
5426396
Compare
SirTerrific
changed the title
Contributor
Author
|
Done — rebased on |
mrtncode
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased on current
main. Conflicts gone, and the overlap with what you merged is dropped.You already have the device info endpoint, so this PR is now only the crop preset it came with:
A Frame TV reports
resolution_type: UHD, so that is the crop which fills the panel without the set rescaling the image. 1920x1080 was the closest fit before.I dropped the content-list sampling this PR also had. It was there to look for a per-image byte size to sum into a capacity figure, and my set does not report one — no reason to carry it when your endpoint answers the useful part.
3 tests added, 67 pass.