Skip to content

fix(knowledge-graph): code-review fixes for 3D view toggle (#3330)#3372

Closed
mrveiss wants to merge 0 commit intoDev_new_guifrom
issue-3330
Closed

fix(knowledge-graph): code-review fixes for 3D view toggle (#3330)#3372
mrveiss wants to merge 0 commit intoDev_new_guifrom
issue-3330

Conversation

@mrveiss
Copy link
Copy Markdown
Owner

@mrveiss mrveiss commented Apr 3, 2026

Summary

Follow-up fixes from code review of PR #3359 (feat: 3D knowledge graph toggle):

Test plan

  • Toggle 2D→3D→2D repeatedly; Cytoscape should render correctly on return
  • Open entity details panel while in 3D; canvas should resize to fill remaining space
  • Toggle 3D on and off many times; check browser memory profile shows no GPU leak
  • Verify toggle button tooltip text appears in all supported locales

Closes #3330
Closes #3370
Closes #3399
Closes #3400
Closes #3401

🤖 Generated with Claude Code

@mrveiss
Copy link
Copy Markdown
Owner Author

mrveiss commented Apr 3, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

@mrveiss
Copy link
Copy Markdown
Owner Author

mrveiss commented Apr 3, 2026

Closing: both commits in this PR were already applied to Dev_new_gui via PRs #3369, #3410, #3411, and #3412. After rebasing, the branch has no diff from the base — the fixes this PR intended are all present on the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant