fix(workflow): prevent checkpoint expiry for paused workflows (#3231)#3448
Merged
fix(workflow): prevent checkpoint expiry for paused workflows (#3231)#3448
Conversation
✅ SSOT Configuration Compliance: Passing🎉 No hardcoded values detected that have SSOT config equivalents! |
AutoBot Phase Validation ResultsSystem Maturity: 0.0% Phase Status:Recommendations: |
Owner
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two independent checkpoint systems both used TTLs too short for human-in-the-loop pauses:
WorkflowCheckpointManager(error_handler.py): TTL extended 7 days → 30 days. Newrefresh_ttl()method resets the countdown on every resume, so a workflow paused near its deadline gets a fresh 30-day window when the operator acts.AsyncRedisSaver(graph.py+ssot_config.py): Default TTL extended 24 hours → 30 days (1440→43200minutes). In-code fallback updated to match.workflow_executor.py:_apply_checkpoints()now callscheckpoint_manager.refresh_ttl()immediately on resume.refresh_ttlbeing logged (never raised).Closes #3231
Test plan
pytest autobot-backend/orchestration/error_handler_test.py -v— all passAUTOBOT_REDIS_CHECKPOINT_TTL_MINUTESenv var overrides the default