8.4 upgrade#100
Conversation
| } | ||
|
|
||
| system(dirname(dirname(__DIR__)) . DIRECTORY_SEPARATOR . "bin/make-thumbs.sh {$album->getId()} $markup {$album->getLocation()} > /dev/null 2>&1 &"); | ||
| system(dirname(__DIR__, 2) . DIRECTORY_SEPARATOR . "bin/make-thumbs.sh {$album->getId()} $markup {$album->getLocation()} > /dev/null 2>&1 &"); |
Check failure
Code scanning / SonarCloud
OS commands should not be vulnerable to command injection attacks
| if (isset($params['preview']) && isset($params['preview']['img']) && $params['preview']['img'] != '') { | ||
| //setup our new image | ||
| copy(dirname(dirname(__DIR__)) . DIRECTORY_SEPARATOR . 'public' . DIRECTORY_SEPARATOR . 'blog' . DIRECTORY_SEPARATOR . $this->preview, $this->directory . DIRECTORY_SEPARATOR . "preview_image-{$this->id}.jpg"); | ||
| copy(dirname(__DIR__, 2) . DIRECTORY_SEPARATOR . 'public' . DIRECTORY_SEPARATOR . 'blog' . DIRECTORY_SEPARATOR . $this->preview, $this->directory . DIRECTORY_SEPARATOR . "preview_image-{$this->id}.jpg"); |
Check failure
Code scanning / SonarCloud
I/O function calls should not be vulnerable to path injection attacks
|
|
||
| <!-- Script to Activate the Gallery --> | ||
| <script> | ||
| var postsFull = new PostsFull( <?php echo $postCount; ?>, <?php echo "[" . implode(",", $categories) . "]"; ?> ); |
Check failure
Code scanning / SonarCloud
Endpoints should not be vulnerable to reflected cross-site scripting (XSS) attacks
|




Trying to upgrade everything to 8.4, including getting more tests and pipeline runs passing