Add support and options for parsing and packing NSData#5
Open
csaftoiu wants to merge 6 commits intomsgpack:masterfrom
Open
Add support and options for parsing and packing NSData#5csaftoiu wants to merge 6 commits intomsgpack:masterfrom
csaftoiu wants to merge 6 commits intomsgpack:masterfrom
Conversation
…ings. this was necessary in my application. I wasn't sure what the desired behavior should be so I left in some options - see the readme for descriptions. by default, it will return an NSNull on failing to decode a string. i felt this was as close to the original behavior and thus most backwards compatible, but really i'd prefer the default to be an exception. i can change this if need be
|
Any chance of getting this merged into master? It's a significant improvement, and it feels right that this is officially supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For my use case I need to ship around raw bytes that aren't utf8-strings. I added support for this.
The default behavior is almost the same: it attempts to parse the bytes into a utf8-string. However, if it fails, it'll raise an exception instead of either returning nil, not adding a key to a dictionary, or raising an exception when trying to add nil to an NSArray.
Additionally you can specify 3 different behaviors: try to parse as string but fallback on NSData, try to parse as string but fallback on NSNull, or always parse as NSData.