Skip to content

Fix Timestamp.from_datetime returning wrong value for pre-epoch datetimes #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 2 commits into from
Jun 2, 2026
+8 −1
Merged

Fix Timestamp.from_datetime returning wrong value for pre-epoch datetimes #662

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ea42eb
Fix Timestamp.from_datetime returning wrong value for pre-epoch times
bysiber Feb 20, 2026
8ddd5d7
add test for pre-epoch datetime
methane Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion msgpack/ext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,4 +167,4 @@ def from_datetime(dt):

:rtype: Timestamp
"""
return Timestamp(seconds=int(dt.timestamp()), nanoseconds=dt.microsecond * 1000)
return Timestamp(seconds=int(dt.timestamp() // 1), nanoseconds=dt.microsecond * 1000)

@methane methane Apr 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback