added datetime into ID to split recurring zoom meetings#11
Open
ajn2004 wants to merge 1 commit intomsherry:masterfrom
Open
added datetime into ID to split recurring zoom meetings#11ajn2004 wants to merge 1 commit intomsherry:masterfrom
ajn2004 wants to merge 1 commit intomsherry:masterfrom
Conversation
Owner
|
Thank you for doing this! I haven't gotten a chance to look it over in depth yet, but at a glance it looks good. Do you know if this will lead to too many events in the org file or other unintended consequences? It's been a while since I've worked in this codebase and I'm a little rusty on it, unfortunately 😅 |
Author
|
I didn't see it making duplicates from events, but I didn't know how the
original problem presented itself so I can't say I've tested against it. If
an event has the same ID and date-time, it should not have a duplicate
entry though, as it will have a duplicate ID and not be interacted with.
…On Wed, Aug 9, 2023 at 2:17 AM Marc Sherry ***@***.***> wrote:
Thank you for doing this! I haven't gotten a chance to look it over in
depth yet, but at a glance it looks good. Do you know if this will lead to
too many events in the org file or other unintended consequences? It's been
a while since I've worked in this codebase and I'm a little rusty on it,
unfortunately 😅
—
Reply to this email directly, view it on GitHub
<#11 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH7YRKVEVL6XRLNAIVHX3JDXUMTPPANCNFSM6AAAAAA24QSMZ4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that google calendar keeps the same ID for repeating zoom meetings that happen in the same meeting room with the same title "i.e. daily standup/weekly all hands".
First event
Second Event
A quick glance at the
DTSTARTvalues show these are different events, but they contain the same UID, which will prevent them from both being recorded to the org file.The change is simply to go from
ID = UID->ID> DSTART:UIDwhich uniquely identifies the recurring event.In the above examples the change would be
This should have the advantage of discriminating between unique events and true duplicates, as true duplicates will also match their
datetimeand be excluded in the/^END:VEVENT/logic.