Skip to content

added datetime into ID to split recurring zoom meetings#11

Open
ajn2004 wants to merge 1 commit intomsherry:masterfrom
ajn2004:feat/time_id
Open

added datetime into ID to split recurring zoom meetings#11
ajn2004 wants to merge 1 commit intomsherry:masterfrom
ajn2004:feat/time_id

Conversation

@ajn2004
Copy link
Copy Markdown

@ajn2004 ajn2004 commented Jul 29, 2023

I noticed that google calendar keeps the same ID for repeating zoom meetings that happen in the same meeting room with the same title "i.e. daily standup/weekly all hands".
First event

BEGIN:VEVENT
DTSTART;TZID=<personal info>:20230726T183000
DTEND;TZID=<personal info>:20230726T190000
DTSTAMP:20230729T035734Z
ORGANIZER;CN=<personal info>
UID:A3D596EA-7CE5-4E6F-9218-C14C82061724
...
DESCRIPTION: <personal info> is inviting you to a scheduled Zoom meeting ...

Second Event

BEGIN:VEVENT
DTSTART;TZID=<personal info>:20230727T183000
DTEND;TZID=<personal info>:20230727T190000
DTSTAMP:20230729T035734Z
ORGANIZER;CN=<personal info>
UID:A3D596EA-7CE5-4E6F-9218-C14C82061724
...
DESCRIPTION: <personal info> is inviting you to a scheduled Zoom meeting ...

A quick glance at the DTSTART values show these are different events, but they contain the same UID, which will prevent them from both being recorded to the org file.

The change is simply to go from ID = UID ->ID> DSTART:UID which uniquely identifies the recurring event.
In the above examples the change would be

old_id_first  = A3D596EA-7CE5-4E6F-9218-C14C82061724
old_id_second = A3D596EA-7CE5-4E6F-9218-C14C82061724

new_id_first  = 20230726T183000:A3D596EA-7CE5-4E6F-9218-C14C82061724
new_id_second = 20230727T183000:A3D596EA-7CE5-4E6F-9218-C14C82061724

This should have the advantage of discriminating between unique events and true duplicates, as true duplicates will also match their datetime and be excluded in the /^END:VEVENT/ logic.

@msherry
Copy link
Copy Markdown
Owner

msherry commented Aug 9, 2023

Thank you for doing this! I haven't gotten a chance to look it over in depth yet, but at a glance it looks good. Do you know if this will lead to too many events in the org file or other unintended consequences? It's been a while since I've worked in this codebase and I'm a little rusty on it, unfortunately 😅

@ajn2004
Copy link
Copy Markdown
Author

ajn2004 commented Aug 9, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants