Skip to content

feat: add "delete on status" option#126

Merged
mshick merged 12 commits intomshick:mainfrom
manan-jadhav-ab:remove-comment-on-success
Mar 13, 2026
Merged

feat: add "delete on status" option#126
mshick merged 12 commits intomshick:mainfrom
manan-jadhav-ab:remove-comment-on-success

Conversation

@manan-jadhav-ab
Copy link
Copy Markdown
Contributor

allows deleting the comment if a certain status has been reached. Useful for removing comments added on failure when success status is reached

allows deleting the comment if a certain status has been reached. Useful for removing comments added on failure when success status is reached
This was referenced Feb 5, 2025
@danyim
Copy link
Copy Markdown

danyim commented Nov 21, 2025

@mshick Could we get this reviewed and merged?

@bsudekum
Copy link
Copy Markdown

bsudekum commented Dec 4, 2025

hey @mshick, big fan of this action! Do you think we could get a review on this PR? It'd be super helpful to have this functionality.

@mshick
Copy link
Copy Markdown
Owner

mshick commented Mar 12, 2026

Hi all, thanks for the contribution @manan-jadhav-ab . Sorry I'm so long in getting to this — over a year! I'll review right away and maybe one of you would be interested in joining as a maintainer? There's not much to do, but I find I don't have a ton of time to commit lately.

If you'd be interested just send me an email (address in my profile). Thanks!

@mshick
Copy link
Copy Markdown
Owner

mshick commented Mar 12, 2026

@manan-jadhav-ab Everything looks good here. If you can resolve the conflict I'll get this merged up.

@manan-jadhav-ab
Copy link
Copy Markdown
Contributor Author

@manan-jadhav-ab Everything looks good here. If you can resolve the conflict I'll get this merged up.

Copy link
Copy Markdown
Owner

@mshick mshick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small items, and a new merge conflict to address.

Comment thread README.md Outdated
Comment thread __tests__/add-pr-comment.test.ts Outdated
@manan-jadhav-ab manan-jadhav-ab requested a review from mshick March 13, 2026 14:11
@mshick mshick changed the title add "delete on status" option feat: add "delete on status" option Mar 13, 2026
@mshick
Copy link
Copy Markdown
Owner

mshick commented Mar 13, 2026

@manan-jadhav-ab I've never figured out how to get some of these actions to run for a contrib PR. Going to open my own copy of this to make sure CI passes, then can merge it.

@mshick mshick mentioned this pull request Mar 13, 2026
3 tasks
@mshick mshick merged commit adbd107 into mshick:main Mar 13, 2026
10 of 11 checks passed
@mshick
Copy link
Copy Markdown
Owner

mshick commented Mar 13, 2026

@all-contributors add @manan-jadhav-ab for code

@allcontributors
Copy link
Copy Markdown
Contributor

@mshick

I've put up a pull request to add @manan-jadhav-ab! 🎉

@mshick
Copy link
Copy Markdown
Owner

mshick commented Mar 13, 2026

closes #108

@mshick
Copy link
Copy Markdown
Owner

mshick commented Mar 13, 2026

Closes #123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants