Skip to content

arm64: dts: qcom: msm8939-huawei-rio: Add initial device tree#385

Draft
bzy-080408 wants to merge 1 commit intomsm8916-mainline:msm8916/6.12.1from
bzy-080408:msm8916/6.12.1
Draft

arm64: dts: qcom: msm8939-huawei-rio: Add initial device tree#385
bzy-080408 wants to merge 1 commit intomsm8916-mainline:msm8916/6.12.1from
bzy-080408:msm8916/6.12.1

Conversation

@bzy-080408
Copy link
Copy Markdown

@bzy-080408 bzy-080408 commented Dec 27, 2024

Not fully working yet.
Tested peripherals:

  • USB network(need kernel support)
  • USB console(need kernel support)
  • WIFI
  • display
  • touchscreen
  • button
  • GPU
    Untested peripherals:
  • USB OTG
    TODO:
  • most of sensor
  • camera
  • USB charging
  • Audio

@bzy-080408 bzy-080408 force-pushed the msm8916/6.12.1 branch 3 times, most recently from c632d86 to 18cb6d5 Compare December 27, 2024 11:20
Comment thread arch/arm64/boot/dts/qcom/msm8939-huawei-rio.dts Outdated
Comment thread arch/arm64/boot/dts/qcom/msm8939-huawei-rio.dts Outdated
Comment thread arch/arm64/boot/dts/qcom/msm8939-huawei-rio.dts Outdated
Comment thread arch/arm64/boot/dts/qcom/msm8939-huawei-rio.dts Outdated
Comment thread arch/arm64/boot/dts/qcom/msm8939-huawei-rio.dts Outdated
Comment thread arch/arm64/boot/dts/qcom/msm8939-huawei-rio.dts Outdated
Signed-off-by: Zhiyuan Bai <Bzy080408@outlook.com>
@@ -0,0 +1,328 @@
// SPDX-License-Identifier: GPL-2.0-only
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message: the prefix is wrong, I'd also appreciate if you could fill in the message like it's done for other device introduction commits.

// SPDX-License-Identifier: GPL-2.0-only

/*
*Copyright (c) 2024 Zhiyuan Bai<Bzy080408@outlook.com>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
*Copyright (c) 2024 Zhiyuan Bai<Bzy080408@outlook.com>
* Copyright (c) 2024 Zhiyuan Bai <Bzy080408@outlook.com>

Comment on lines +132 to +133
};
&blsp_i2c5 {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
};
&blsp_i2c5 {
};
&blsp_i2c5 {

Comment on lines +137 to +139
compatible = "cypress,tt21000";

reg = <0x1c>;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
compatible = "cypress,tt21000";
reg = <0x1c>;
compatible = "cypress,tt21000";
reg = <0x1c>;

Comment on lines +168 to +202
&mdss {
status = "okay";
};

&mdss_dsi0 {
pinctrl-0 = <&mdss_default>;
pinctrl-1 = <&mdss_sleep>;
pinctrl-names = "default", "sleep";
status = "okay";

panel@0 {
compatible = "huawei,rio-panel";
reg = <0>;

vsp-supply = <&reg_lcd_pos>;
vsn-supply = <&reg_lcd_neg>;
reset-gpios = <&tlmm 25 GPIO_ACTIVE_LOW>;

port {
panel_in: endpoint {
remote-endpoint = <&mdss_dsi0_out>;
};
};
};
};

&mdss_dsi0_out {
data-lanes = <0 1 2 3>;
remote-endpoint = <&panel_in>;
};

&mdss_dsi0_phy {
qcom,dsi-phy-regulator-ldo-mode;
status = "okay";
};
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is optional but if you split up display into a separate commit (i.e. like 3e3d375) then you can upstream most of the other changes already, which I'd greatly appreciate

@stephan-gh stephan-gh marked this pull request as draft September 15, 2025 13:51
feryw pushed a commit to feryw/msm8916-kernel that referenced this pull request Apr 29, 2026
The current selftest sk_bypass_prot_mem only supports 4K page.
When running with 64K page on arm64, the following failure happens:
  ...
  check_bypass:FAIL:no bypass unexpected no bypass: actual 3 <= expected 32
  ...
  msm8916-mainline#385/1   sk_bypass_prot_mem/TCP  :FAIL
  ...
  check_bypass:FAIL:no bypass unexpected no bypass: actual 4 <= expected 32
  ...
  msm8916-mainline#385/2   sk_bypass_prot_mem/UDP  :FAIL
  ...

Adding support to 64K page as well fixed the failure.

Cc: Kuniyuki Iwashima <kuniyu@google.com>
Signed-off-by: Yonghong Song <yonghong.song@linux.dev>
Link: https://lore.kernel.org/r/20260113061028.3798326-1-yonghong.song@linux.dev
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants