Skip to content

Prevent unexpected Claude Keychain prompts - #20

Merged
mstallone merged 1 commit into
mainfrom
clarify-arc-safe-storage
Jul 30, 2026
Merged

Prevent unexpected Claude Keychain prompts#20
mstallone merged 1 commit into
mainfrom
clarify-arc-safe-storage

Conversation

@mstallone

Copy link
Copy Markdown
Owner

TL;DR

Keep Claude credential discovery and background refreshes prompt-free, with Keychain approval limited to manual refreshes.

What was happening

  • Automatic credential reads and token updates could trigger password dialogs or select a lower-priority login.
  • Denying one approval could lead to repeated or unrelated prompts.

What this changes

  • Uses interaction-forbidden Security.framework access for automatic reads and updates, and fails closed when Claude Code Keychain state is unresolved.
  • Validates first-run credentials and stops prompt handling after a denial.

Tests

  • swift test
  • ./script/build_and_run.sh verify

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 385899cefa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Sources/Runway/Services/SystemClients.swift
@mstallone
mstallone merged commit f5ca794 into main Jul 30, 2026
1 check passed
@mstallone
mstallone deleted the clarify-arc-safe-storage branch July 30, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant